From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0F700235 for ; Mon, 23 Apr 2018 12:56:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2018 03:56:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,317,1520924400"; d="scan'208";a="36307996" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga006.jf.intel.com with ESMTP; 23 Apr 2018 03:56:21 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 23 Apr 2018 11:56:20 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by IRSMSX156.ger.corp.intel.com ([169.254.3.229]) with mapi id 14.03.0319.002; Mon, 23 Apr 2018 11:56:20 +0100 From: "Mokhtar, Amr" To: Thomas Monjalon , "Chalupnik, KamilX" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] doc: update bbdev library documentation Thread-Index: AQHTzB4jI/bo0PM7CUixG4Lnjd88O6QNRMIAgAD/n/A= Date: Mon, 23 Apr 2018 10:56:20 +0000 Message-ID: <3D3765A8CDB52A4C8B410430AA19CB236ECAFFC8@IRSMSX101.ger.corp.intel.com> References: <20180404140602.9344-1-kamilx.chalupnik@intel.com> <2713250.YhKZBbbERd@xps> In-Reply-To: <2713250.YhKZBbbERd@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWQ3NWZhOWMtZDZkMy00MjBhLWI3YzItNzg4MTNmNGRiMDNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJZcUtlbTQ2RXdBbDlkMjVoVnFXVzE1Wk1iZVRKXC92MTNDakU1dWMwWlpIWlJyQXBiTEdNMWh1Nzh6SG1IM3hxVyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: update bbdev library documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 10:56:25 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Sunday 22 April 2018 21:17 > To: Chalupnik, KamilX > Cc: dev@dpdk.org; Mokhtar, Amr > Subject: Re: [dpdk-dev] [PATCH] doc: update bbdev library documentation >=20 > Hi, >=20 > 04/04/2018 16:05, KamilX Chalupnik: > > From: "Chalupnik, KamilX" >=20 > > doc/guides/prog_guide/bbdev.rst | 247 > +++++++++++++++++++++++--- > > doc/guides/prog_guide/img/turbo_tb_decode.png | Bin 0 -> 43552 > bytes > > doc/guides/prog_guide/img/turbo_tb_encode.png | Bin 0 -> 46944 > bytes > > 3 files changed, 222 insertions(+), 25 deletions(-) > > create mode 100644 doc/guides/prog_guide/img/turbo_tb_decode.png > > create mode 100644 doc/guides/prog_guide/img/turbo_tb_encode.png >=20 > No, sorry, you cannot add binary file in this repository. > It is an Open Source project, we provide sources. > For figures, the SVG format is preferred. >=20 > I'm sorry that your Intel colleagues did not warn you. >=20 I wasn't aware there is specific preference for figures, this can be fixed. There is no specific reason for choosing .png except that there are files a= lready in prog_guide/img/* of type .png. So it was assumed that its ok. And BTW, did I miss it somewhere in DPDK documentation what particular imag= e types should be submitted. Will get this fixed. Thanks.