From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 161C82B9C for ; Mon, 23 Apr 2018 14:15:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2018 05:15:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,318,1520924400"; d="scan'208";a="49157080" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga001.fm.intel.com with ESMTP; 23 Apr 2018 05:15:41 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by IRSMSX154.ger.corp.intel.com ([169.254.12.234]) with mapi id 14.03.0319.002; Mon, 23 Apr 2018 13:15:40 +0100 From: "Mokhtar, Amr" To: Thomas Monjalon CC: "Chalupnik, KamilX" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] doc: update bbdev library documentation Thread-Index: AQHTzB4jI/bo0PM7CUixG4Lnjd88O6QNRMIAgAD/n/D///p3AIAAIUeA Date: Mon, 23 Apr 2018 12:15:40 +0000 Message-ID: <3D3765A8CDB52A4C8B410430AA19CB236ECB0090@IRSMSX101.ger.corp.intel.com> References: <20180404140602.9344-1-kamilx.chalupnik@intel.com> <2713250.YhKZBbbERd@xps> <3D3765A8CDB52A4C8B410430AA19CB236ECAFFC8@IRSMSX101.ger.corp.intel.com> <4551437.8ZCrZuEaxO@xps> In-Reply-To: <4551437.8ZCrZuEaxO@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDZhYzNlNjctYTEwNC00MzJkLWIwYTQtN2ZmMWZiZDk2YmM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJjeHZwaXdCZkRsNnFQUkZadGkxMzIrQWVoSnZyXC9DbWl0ZmV5bEtRWjd2RXpPMkN5UGNDNWFoXC91Q1VZR3BYd08ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: update bbdev library documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 12:15:47 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday 23 April 2018 12:12 > To: Mokhtar, Amr > Cc: Chalupnik, KamilX ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: update bbdev library documentation >=20 > 23/04/2018 12:56, Mokhtar, Amr: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 04/04/2018 16:05, KamilX Chalupnik: > > > > From: "Chalupnik, KamilX" > > > > > > > doc/guides/prog_guide/bbdev.rst | 247 > > > +++++++++++++++++++++++--- > > > > doc/guides/prog_guide/img/turbo_tb_decode.png | Bin 0 -> 43552 > > > bytes > > > > doc/guides/prog_guide/img/turbo_tb_encode.png | Bin 0 -> 46944 > > > bytes > > > > 3 files changed, 222 insertions(+), 25 deletions(-) > > > > create mode 100644 > doc/guides/prog_guide/img/turbo_tb_decode.png > > > > create mode 100644 > doc/guides/prog_guide/img/turbo_tb_encode.png > > > > > > No, sorry, you cannot add binary file in this repository. > > > It is an Open Source project, we provide sources. > > > For figures, the SVG format is preferred. > > > > > > I'm sorry that your Intel colleagues did not warn you. > > > > > > > I wasn't aware there is specific preference for figures, this can be fi= xed. > > There is no specific reason for choosing .png except that there are fil= es > already > > in prog_guide/img/* of type .png. So it was assumed that its ok. > > And BTW, did I miss it somewhere in DPDK documentation what > particular image > > types should be submitted. >=20 > Yes, it is in this doc: > http://dpdk.org/doc/guides/contributing/documentation.html#ima > ges > Ok, perfect. Will get it sorted accordingly.. Thanks!! > > Will get this fixed. Thanks. >=20 > Thanks >=20