From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E4E281BAA8; Fri, 14 Dec 2018 13:52:39 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Dec 2018 04:52:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,353,1539673200"; d="scan'208";a="98748296" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga007.jf.intel.com with ESMTP; 14 Dec 2018 04:52:37 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 14 Dec 2018 12:52:36 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.61]) by irsmsx111.ger.corp.intel.com ([169.254.2.183]) with mapi id 14.03.0415.000; Fri, 14 Dec 2018 12:52:35 +0000 From: "Mokhtar, Amr" To: Neil Horman , David Marchand CC: Akhil Goyal , "dev@dpdk.org" , "stable@dpdk.org" , "tredaelli@redhat.com" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH] bbdev: add missing experimental tags Thread-Index: AQHUjBQQFhZ4TT0+EUuJ8Yk+z4RQrKV+DbiAgAABwYCAACtnAIAAAtdQ Date: Fri, 14 Dec 2018 12:52:35 +0000 Message-ID: <3D3765A8CDB52A4C8B410430AA19CB23709189AF@IRSMSX104.ger.corp.intel.com> References: <1543957065-20990-1-git-send-email-david.marchand@redhat.com> <20181214123538.GA28669@hmswarspite.think-freely.org> In-Reply-To: <20181214123538.GA28669@hmswarspite.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTJkOTk4MjktZmFjOS00YWYzLTkxOGQtYTlmNzNhMTQ2YWI3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTmMxblZmajFIYW5aSE1xa0pSeit2Y2pKYjV2RDBpRVVWWHV1bkNJUGQ2cTJlelRBd0NlczlSVWNRVnlIM2lqayJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] bbdev: add missing experimental tags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 12:52:40 -0000 > -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Friday 14 December 2018 12:36 > To: David Marchand > Cc: Akhil Goyal ; dev@dpdk.org; stable@dpdk.org; > tredaelli@redhat.com; Yigit, Ferruh ; Mokhtar, > Amr > Subject: Re: [dpdk-dev] [PATCH] bbdev: add missing experimental tags >=20 > On Fri, Dec 14, 2018 at 11:00:17AM +0100, David Marchand wrote: > > On Fri, Dec 14, 2018 at 10:54 AM Akhil Goyal > wrote: > > > > > Hi David, > > > > > > I can see that there are other APIs as well which are not marked as > > > experimental like rte_bbdev_dec_op_alloc_bulk > > > rte_bbdev_dec_op_free_bulk, rte_bbdev_enqueue_enc_ops etc. > > > It seems that all APIs defined in rte_bbdev_op.h are missing their experimental tags. > > > > Well, that's the problem with inlines... > > I don't think we can detect these easily. > > > We can, if the symbols get added to the version map as they should. But > (as you > note), because these functions are inlines, theres no error thrown for no= t > following that rule. >=20 Right, there are some APIs missing in the map file. I am submitting a patch of those functions missing. > > > > -- > > David Marchand