From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 92D42108A for ; Tue, 7 Mar 2017 16:09:52 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2017 07:08:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,258,1484035200"; d="scan'208";a="65131509" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 07 Mar 2017 07:08:27 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 7 Mar 2017 07:08:26 -0800 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.172]) by fmsmsx117.amr.corp.intel.com ([169.254.3.201]) with mapi id 14.03.0248.002; Tue, 7 Mar 2017 07:08:26 -0800 From: "Wiles, Keith" To: Pascal Mazon CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 0/4] net/tap: support flow API Thread-Index: AQHSlpvua15bGeJgc06megmwui+1+qGKAVyAgAAA3oA= Date: Tue, 7 Mar 2017 15:08:25 +0000 Message-ID: <3D8C8E20-E958-4797-AD95-1458ED33D550@intel.com> References: <20170307160519.6b8ff31b@paques.dev.6wind.com> In-Reply-To: <20170307160519.6b8ff31b@paques.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.71.106] Content-Type: text/plain; charset="us-ascii" Content-ID: <03F90A9895FB4C43A32015BC8F279385@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/4] net/tap: support flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 15:09:53 -0000 > On Mar 7, 2017, at 9:05 AM, Pascal Mazon wrote: >=20 > Hi Keith, >=20 > I'm working on a v3 for that series: >=20 > - I added info regarding flow API support in tap.rst doc > - I fixed support for kernels where flower/vlan was not supported. >=20 > Do you have any other remarks, or can I send the v3 (hopefully ok for > integration)? >=20 > I'll send a v2 for the latest series (introducing remote capture), > because struct pmd_internals changed (whitespaces). > Same question there, do you have remarks? I think I am ok with everything we discussed and you can send your v2/v3 wh= en you want. >=20 > Thank you. >=20 > Best regards, > Pascal >=20 > On Mon, 6 Mar 2017 18:05:26 +0100 > Pascal Mazon wrote: >=20 >> This series add support for the flow API in tap PMD. >>=20 >> It enables filtering specific packets incoming on the tap netdevice, >> to process only desired ones. Under the hood, it uses kernel TC >> (traffic control), which takes place very early in the stack, and >> supports most common pattern items and actions defined in the flow >> API. >>=20 >> This series applies on top of: >>=20 >> [PATCH 0/6] net/tap: add additional management ops >>=20 >> v2 changes: >> - support compilation on kernels < 4.2 (where flower support >> appeared) >> - set whitespaces in tap.h >> - remove unnecessary goto >>=20 >> Pascal Mazon (4): >> net/tap: move private elements to external header >> net/tap: add preliminary support for rte_flow >> net/tap: add netlink back-end for flow API >> net/tap: add basic flow API patterns and actions >>=20 >> doc/guides/nics/features/tap.ini | 1 + >> drivers/net/tap/Makefile | 44 ++ >> drivers/net/tap/rte_eth_tap.c | 94 ++-- >> drivers/net/tap/tap.h | 77 +++ >> drivers/net/tap/tap_flow.c | 1084 >> ++++++++++++++++++++++++++++++++++++++ >> drivers/net/tap/tap_flow.h | 58 ++ >> drivers/net/tap/tap_netlink.c | 367 +++++++++++++ >> drivers/net/tap/tap_netlink.h | 69 +++ >> drivers/net/tap/tap_tcmsgs.c | 378 +++++++++++++ >> drivers/net/tap/tap_tcmsgs.h | 63 +++ 10 files changed, 2202 >> insertions(+), 33 deletions(-) create mode 100644 >> drivers/net/tap/tap.h create mode 100644 drivers/net/tap/tap_flow.c >> create mode 100644 drivers/net/tap/tap_flow.h >> create mode 100644 drivers/net/tap/tap_netlink.c >> create mode 100644 drivers/net/tap/tap_netlink.h >> create mode 100644 drivers/net/tap/tap_tcmsgs.c >> create mode 100644 drivers/net/tap/tap_tcmsgs.h >>=20 >=20 Regards, Keith