From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7DE041D47; Thu, 23 Feb 2023 07:28:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8054342F9A; Thu, 23 Feb 2023 07:28:50 +0100 (CET) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by mails.dpdk.org (Postfix) with ESMTP id A1C9A4021F for ; Thu, 23 Feb 2023 07:28:48 +0100 (CET) Received: by mail-ed1-f53.google.com with SMTP id eg37so35054962edb.12 for ; Wed, 22 Feb 2023 22:28:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nEBDAO4coWiMO+kyzn8Lngaveu6syFmW7y79/Q7g5hc=; b=CXyIOKHRm/47DgmG+oSd244kss4CWHjWXxNlWNyMMhF9ekbZD9lfUUmpUt7y2xy04M psWZpL7ZcpPHPYhxNCNOuIaaPhbeNUYmt7ob0Pa6URo74RXnVYi2Ix2sB/6g9SY8XOS1 rvp9fAIY9kBOHZsLwEvUaaEX1JW98RkEXElsIsWlwSP1gBJOkPDNNUefIZrLzlWCDLi1 3x+ajcBuv7XuX3VVv+0/26h0oZra4ly/TP4V/I3uBpYFwlktjqVDEU8VdXU9vS3UZwhi Cgf/QC/voomMqfHCMMShC+AYInDLBP4bF1diANH/07E/661ZTzk3haUh0KenPrUK3erd 8MnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nEBDAO4coWiMO+kyzn8Lngaveu6syFmW7y79/Q7g5hc=; b=zwTgr60p44wRG/rR95/aRC1CVlcJejacAGaSVtnev1/tEGOlvxF10L+oZBs9keap2P bZcPD4dDh+QX/7aNHCmqFwWFN8k10HY6WqCbcmQWo2H/d1Rh5DEHdapMIjylva7tgfq9 hPz+C2Lg7Q3iL+L1a+WCA3xt3zssAPNP00rrDO3h9LV0WMEMTsEJlUH5gd9FmoiXRjJr aSslIpzfhhIfxtHjhS2E/2s98obaYuLLGD/KUh0/KQ0t7quz2xUq2tyw4XUpkNyMCy6C tGtFNFCiECE/x3FFIPfu6xsy2EQfYdEbJUTGEuHCtCoPCRRn0dyHSrb/KwJYRc30KAmz 3xGw== X-Gm-Message-State: AO0yUKUM0oJu14M8/gHuD8lbuy/YOD1hFrW7yTtHWFAQruDVxz9/9Mmg oEmMLVMdMuUVWcDXvgsRvUk= X-Google-Smtp-Source: AK7set9iyYb95Tp7pqV/sFqQM+qAPR8EcctD4vy1a8f8NM+7QDNuLAh35zJgW8F7EQo03HTJHyiuew== X-Received: by 2002:a17:907:7e84:b0:8ea:a647:a5aa with SMTP id qb4-20020a1709077e8400b008eaa647a5aamr3719570ejc.38.1677133727981; Wed, 22 Feb 2023 22:28:47 -0800 (PST) Received: from smtpclient.apple ([176.41.30.17]) by smtp.gmail.com with ESMTPSA id u23-20020a50d517000000b004acdf09027esm4561780edi.4.2023.02.22.22.28.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Feb 2023 22:28:47 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats From: Levend Sayar In-Reply-To: Date: Thu, 23 Feb 2023 09:28:36 +0300 Cc: Ferruh Yigit , "dev@dpdk.org" Content-Transfer-Encoding: 7bit Message-Id: <3E7EF1E9-7A5A-4F67-BF2E-B5B6C3BB9911@gmail.com> References: <20230221141350.12335-1-levendsayar@gmail.com> <20230221141814.13674-1-levendsayar@gmail.com> <68DCC243-8E0A-4BE9-8D7F-2D704B427EAE@gmail.com> To: "Guo, Junfeng" X-Mailer: Apple Mail (2.3731.300.101.1.3) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thanks Junfeng for acknowledging. > On 23 Feb 2023, at 05:49, Guo, Junfeng wrote: > > Thanks! > >> -----Original Message----- >> From: Levend Sayar >> Sent: Wednesday, February 22, 2023 00:44 >> To: Ferruh Yigit >> Cc: Guo, Junfeng ; dev@dpdk.org >> Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats >> >> Thanks Ferruh for the review. >> >>> On 21 Feb 2023, at 18:58, Ferruh Yigit wrote: >>> >>> On 2/21/2023 2:18 PM, Levend Sayar wrote: >>>> Google Virtual NIC rx/tx queue stats are added as extended stats. >>>> >>>> Signed-off-by: Levend Sayar >>> >>> Reviewed-by: Ferruh Yigit >>> > > Acked-by: Junfeng Guo > >>> <...> >>> >>>> @@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) >>>> if (nb_alloc <= rxq->nb_avail) { >>>> diag = rte_pktmbuf_alloc_bulk(rxq->mpool, &rxq- >>> sw_ring[idx], nb_alloc); >>>> if (diag < 0) { >>>> + rxq->stats.no_mbufs_bulk++; >>> >>> It is not common to record bulk alloc failures, but as 'no_mbufs' >>> already recorded conventionally, I guess it is OK to keep this extra >>> stat if it is helpful. >>> >