Re: [dpdk-dev] [PATCH] cmdline: finish at EOF

["Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>]

Hi Olivier,

Great, so then maybe we should plan for an update of the DPDK command line library to your latest code base.

Are the code changes massive, i.e. would this be a big task?

Thanks,
Cristian

-----Original Message-----
From: Olivier MATZ [mailto:olivier.matz@6wind.com] 
Sent: Monday, May 26, 2014 3:27 PM
To: Dumitrescu, Cristian; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] cmdline: finish at EOF

Hi Cristian,

On 05/23/2014 05:32 PM, Olivier MATZ wrote:
> On 05/23/2014 05:21 PM, Cristian Dumitrescu wrote:
>> Bug fix in cmdline library to allow return on EOF as opposed to
>> infinite loop.
>>
>> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>> ---
>>   lib/librte_cmdline/cmdline.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>   mode change 100644 => 100755 lib/librte_cmdline/cmdline.c
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

By the way, I just noticed that this bug had already been fixed into
my cmdline project onto my personal website some time ago:
http://git.droids-corp.org/?p=libcmdline.git;a=commitdiff;h=52e1d5772d1f465a013e65b8ae6e43a027438ed6

Regards,
Olivier
--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.