From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cristian.dumitrescu@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id CB98BAFD8
 for <dev@dpdk.org>; Tue, 27 May 2014 20:38:12 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 27 May 2014 11:38:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.98,921,1392192000"; d="scan'208";a="545671415"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by fmsmga002.fm.intel.com with ESMTP; 27 May 2014 11:38:22 -0700
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.105]) by
 IRSMSX103.ger.corp.intel.com ([169.254.3.58]) with mapi id 14.03.0123.003;
 Tue, 27 May 2014 19:38:21 +0100
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Olivier MATZ <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] cmdline: finish at EOF
Thread-Index: AQHPeO6kUTQG2PrIIUy7cT06KM8zHJtUwsdA
Date: Tue, 27 May 2014 18:38:21 +0000
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891261B1BE8A9@IRSMSX102.ger.corp.intel.com>
References: <1400858484-2402-1-git-send-email-cristian.dumitrescu@intel.com>
 <537F6A02.3020106@6wind.com> <53834F51.4070703@6wind.com>
In-Reply-To: <53834F51.4070703@6wind.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH] cmdline: finish at EOF
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 May 2014 18:38:13 -0000

Hi Olivier,

Great, so then maybe we should plan for an update of the DPDK command line =
library to your latest code base.

Are the code changes massive, i.e. would this be a big task?

Thanks,
Cristian

-----Original Message-----
From: Olivier MATZ [mailto:olivier.matz@6wind.com] =

Sent: Monday, May 26, 2014 3:27 PM
To: Dumitrescu, Cristian; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] cmdline: finish at EOF

Hi Cristian,

On 05/23/2014 05:32 PM, Olivier MATZ wrote:
> On 05/23/2014 05:21 PM, Cristian Dumitrescu wrote:
>> Bug fix in cmdline library to allow return on EOF as opposed to
>> infinite loop.
>>
>> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>> ---
>>   lib/librte_cmdline/cmdline.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>   mode change 100644 =3D> 100755 lib/librte_cmdline/cmdline.c
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

By the way, I just noticed that this bug had already been fixed into
my cmdline project onto my personal website some time ago:
http://git.droids-corp.org/?p=3Dlibcmdline.git;a=3Dcommitdiff;h=3D52e1d5772=
d1f465a013e65b8ae6e43a027438ed6

Regards,
Olivier
--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the s=
ole use of the intended recipient(s). Any review or distribution by others =
is strictly prohibited. If you are not the intended recipient, please conta=
ct the sender and delete all copies.