From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 10215B0A7 for ; Wed, 18 Jun 2014 12:08:21 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 18 Jun 2014 03:08:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,499,1400050800"; d="scan'208";a="549745993" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 18 Jun 2014 03:08:35 -0700 Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 18 Jun 2014 11:08:30 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.105]) by IRSMSX153.ger.corp.intel.com ([169.254.9.252]) with mapi id 14.03.0123.003; Wed, 18 Jun 2014 11:08:30 +0100 From: "Dumitrescu, Cristian" To: "Burakov, Anatoly" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] vfio: open VFIO container at startup rather than during init Thread-Index: AQHPikzmqXPLJ58Ywk2jfElMWsSSHZt2kG4AgAAUuLA= Date: Wed, 18 Jun 2014 10:08:30 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891261B1C6009@IRSMSX102.ger.corp.intel.com> References: <4bf447650cc99e316e6427e3a1c134dd417af4ec.1402996488.git.anatoly.burakov@intel.com> <5481188.YHqy5HFYGY@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] vfio: open VFIO container at startup rather than during init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jun 2014 10:08:22 -0000 Hi Anatoly, I would suggest we add a log message explaining which mechanism is loaded (= igb_uio/vfio) and why (e.g. tried vfio first but container could not be ope= ned, so falling back to igb_uio, etc). Regards, Cristian -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Burakov, Anatoly Sent: Wednesday, June 18, 2014 9:57 AM To: Thomas Monjalon Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vfio: open VFIO container at startup rather= than during init Hi Thomas, > Subject: Re: [dpdk-dev] [PATCH] vfio: open VFIO container at startup rath= er > than during init > = > > Signed-off-by: Anatoly Burakov > = > Please Anatoly, could you provide a text explaining what was broken and > why you fixed it this way? What was broken was if, for some reason, VFIO is loaded but the user can't = initialize it (an example would be wrong permissions, or unsupported IOMMU = type, which is what Bruce seems to be having... which shouldn't happen as f= ar as I know, but there's nothing I can do on DPDK's side to fix this as th= is is the kernel reporting wrong kind of IOMMU type), DPDK would fail to lo= ad. The fix makes DPDK simply not try VFIO support at all if the container = cannot be opened for some reason. Best regards, Anatoly Burakov DPDK SW Engineer -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others = is strictly prohibited. If you are not the intended recipient, please conta= ct the sender and delete all copies.