From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Xie, Huawei" <huawei.xie@intel.com>,
"Liu, Yong" <yong.liu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/qos_sched: fix flow pause after 2M packets
Date: Thu, 3 Jul 2014 10:54:25 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891262D69A94A@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <C37D651A908B024F974696C65296B57B0F2283B0@SHSMSX101.ccr.corp.intel.com>
>>How about "mbufs += ret" rather than "mbufs = (struct rte_mbuf **)&mbufs[ret]"?
Functionally it is the same, but "mbufs = (struct rte_mbuf **)&mbufs[ret]" is likely less prone to compiler warnings, so my vote is to keep it as it is and get this patch integrated asap into 1.7.
Regards,
Cristian
--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2014-07-03 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 8:59 Yong Liu
2014-07-03 10:07 ` Xie, Huawei
2014-07-03 10:54 ` Dumitrescu, Cristian [this message]
2014-07-03 10:55 ` Dumitrescu, Cristian
2014-07-03 14:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D891262D69A94A@IRSMSX102.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).