From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8782030E for ; Thu, 3 Jul 2014 12:54:08 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 03 Jul 2014 03:54:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,594,1400050800"; d="scan'208";a="556888592" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 03 Jul 2014 03:54:27 -0700 Received: from irsmsx105.ger.corp.intel.com (163.33.3.28) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 3 Jul 2014 11:54:26 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.76]) by IRSMSX105.ger.corp.intel.com ([169.254.7.76]) with mapi id 14.03.0123.003; Thu, 3 Jul 2014 11:54:27 +0100 From: "Dumitrescu, Cristian" To: "Xie, Huawei" , "Liu, Yong" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/qos_sched: fix flow pause after 2M packets Thread-Index: AQHPlp07yQiD+hPv50a129ZEwkpwGZuOHb/ggAAOlTA= Date: Thu, 3 Jul 2014 10:54:25 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891262D69A94A@IRSMSX102.ger.corp.intel.com> References: <1404377976-9231-1-git-send-email-yong.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] examples/qos_sched: fix flow pause after 2M packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2014 10:54:09 -0000 >>How about "mbufs +=3D ret" rather than "mbufs =3D (struct rte_mbuf **)&mb= ufs[ret]"? = Functionally it is the same, but "mbufs =3D (struct rte_mbuf **)&mbufs[ret]= " is likely less prone to compiler warnings, so my vote is to keep it as it= is and get this patch integrated asap into 1.7. Regards, Cristian -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others = is strictly prohibited. If you are not the intended recipient, please conta= ct the sender and delete all copies.