From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1B18A2E81 for ; Thu, 27 Nov 2014 11:35:24 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 27 Nov 2014 02:35:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,468,1413270000"; d="scan'208";a="644449355" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga002.jf.intel.com with ESMTP; 27 Nov 2014 02:35:00 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX109.ger.corp.intel.com ([169.254.13.244]) with mapi id 14.03.0195.001; Thu, 27 Nov 2014 10:34:59 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon , Takayuki Usui Thread-Topic: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable key size ext and lru Thread-Index: AQHQCb6V15zHHgkGUU6xW/F3Vk4/NZx0RL/Q Date: Thu, 27 Nov 2014 10:34:59 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126322D69FB@IRSMSX108.ger.corp.intel.com> References: <1407728582-19637-1-git-send-email-takayuki@midokura.com> <2469278.NhId8OL9C5@xps13> In-Reply-To: <2469278.NhId8OL9C5@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "Nemeth, Balazs" Subject: Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable key size ext and lru X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 10:35:25 -0000 Hi Thomas, Yes, we can confirm that this patch is identical to one of the fixes provid= ed by Balazs with his set of patches which were already applied. Sorry for not seeing this patch earlier. Thank you, Takayuki San for doing this work and sending us the patch! Regards, Cristian -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] = Sent: Wednesday, November 26, 2014 9:18 PM To: Takayuki Usui; Dumitrescu, Cristian Cc: dev@dpdk.org; Nemeth, Balazs Subject: Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable= key size ext and lru Hi, 2014-08-11 12:43, Takayuki Usui: > Signed-off-by: Takayuki Usui > --- > lib/librte_table/rte_table_hash_ext.c | 2 +- > lib/librte_table/rte_table_hash_lru.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > = > diff --git a/lib/librte_table/rte_table_hash_ext.c b/lib/librte_table/rte= _table_hash_ext.c > index 6e26d98..8b86fab 100644 > --- a/lib/librte_table/rte_table_hash_ext.c > +++ b/lib/librte_table/rte_table_hash_ext.c > @@ -221,7 +221,7 @@ rte_table_hash_ext_create(void *params, int socket_id= , uint32_t entry_size) > /* Internal */ > t->bucket_mask =3D t->n_buckets - 1; > t->key_size_shl =3D __builtin_ctzl(p->key_size); > - t->data_size_shl =3D __builtin_ctzl(p->key_size); > + t->data_size_shl =3D __builtin_ctzl(entry_size); > = > /* Tables */ > table_meta_offset =3D 0; > diff --git a/lib/librte_table/rte_table_hash_lru.c b/lib/librte_table/rte= _table_hash_lru.c > index d1a4984..bf92e81 100644 > --- a/lib/librte_table/rte_table_hash_lru.c > +++ b/lib/librte_table/rte_table_hash_lru.c > @@ -192,7 +192,7 @@ rte_table_hash_lru_create(void *params, int socket_id= , uint32_t entry_size) > /* Internal */ > t->bucket_mask =3D t->n_buckets - 1; > t->key_size_shl =3D __builtin_ctzl(p->key_size); > - t->data_size_shl =3D __builtin_ctzl(p->key_size); > + t->data_size_shl =3D __builtin_ctzl(entry_size); > = > /* Tables */ > table_meta_offset =3D 0; A similar patch has been recently applied: http://dpdk.org/browse/dpdk/commit/?id=3D8595428e50 Cristian, as the author of this library, it would be appreciated that you review and ack such patch. It's important to accept contributions and give credit to the first author of a patch. Thanks -- = Thomas -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others = is strictly prohibited. If you are not the intended recipient, please conta= ct the sender and delete all copies.