From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AFDFB8032 for ; Thu, 4 Dec 2014 16:23:47 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 04 Dec 2014 07:22:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,516,1413270000"; d="scan'208";a="618612533" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga001.jf.intel.com with ESMTP; 04 Dec 2014 07:23:45 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX153.ger.corp.intel.com ([163.33.192.75]) with mapi id 14.03.0195.001; Thu, 4 Dec 2014 15:23:44 +0000 From: "Dumitrescu, Cristian" To: "Richardson, Bruce" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] table: fix table_array for incomplete bitmask Thread-Index: AQHQD84vOTKuSIpWw0KnF+vfvOvWiJx/jMGQ Date: Thu, 4 Dec 2014 15:23:43 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126322DA654@IRSMSX108.ger.corp.intel.com> References: <1417703052-32575-1-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1417703052-32575-1-git-send-email-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] table: fix table_array for incomplete bitmask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2014 15:23:48 -0000 Acked by: -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson Sent: Thursday, December 4, 2014 2:24 PM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH] table: fix table_array for incomplete bitmask When a lookup was done on a table_array structure with an incomplete bitmask, the results was always zero hits. This was because the pkts_mask value was cleared as we process each entry, and the result was assigned at the end of the loop, when pkts_mask was zero. Changing the assignment to occur at the start, before the pkts_mask gets cleared, fixes this issue. Signed-off-by: Bruce Richardson --- lib/librte_table/rte_table_array.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_table/rte_table_array.c b/lib/librte_table/rte_tabl= e_array.c index 0b1d42a..4d3c05e 100644 --- a/lib/librte_table/rte_table_array.c +++ b/lib/librte_table/rte_table_array.c @@ -164,6 +164,8 @@ rte_table_array_lookup( { struct rte_table_array *t =3D (struct rte_table_array *) table; = + *lookup_hit_mask =3D pkts_mask; + if ((pkts_mask & (pkts_mask + 1)) =3D=3D 0) { uint64_t n_pkts =3D __builtin_popcountll(pkts_mask); uint32_t i; @@ -190,8 +192,6 @@ rte_table_array_lookup( } } = - *lookup_hit_mask =3D pkts_mask; - return 0; } = -- = 1.9.3 -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others = is strictly prohibited. If you are not the intended recipient, please conta= ct the sender and delete all copies.