From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E000AB789 for ; Fri, 20 Feb 2015 18:54:33 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 20 Feb 2015 09:50:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,616,1418112000"; d="scan'208";a="688478231" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 20 Feb 2015 09:54:30 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0195.001; Fri, 20 Feb 2015 17:54:29 +0000 From: "Dumitrescu, Cristian" To: Stephen Hemminger , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 1/7] rte_sched: make RED optional at runtime Thread-Index: AQHQQQnNEbQ6kgcV70CxqRW8wE2tR5z56A1w Date: Fri, 20 Feb 2015 17:54:28 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891263231B219@IRSMSX108.ger.corp.intel.com> References: <1423116294-17080-1-git-send-email-stephen@networkplumber.org> In-Reply-To: <1423116294-17080-1-git-send-email-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Cc: Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH v2 1/7] rte_sched: make RED optional at runtime X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 17:54:34 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Thursday, February 5, 2015 6:05 AM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v2 1/7] rte_sched: make RED optional at runtime > = > From: Stephen Hemminger > = > Want to be able to build with RTE_SCHED_RED enabled but > allow disabling RED on a per-queue basis at runtime. > = > RED is disabled unless min/max thresholds set. > = > Signed-off-by: Stephen Hemmminger > --- > lib/librte_sched/rte_sched.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > = > diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c > index 95dee27..6928c98 100644 > --- a/lib/librte_sched/rte_sched.c > +++ b/lib/librte_sched/rte_sched.c > @@ -636,6 +636,12 @@ rte_sched_port_config(struct > rte_sched_port_params *params) > uint32_t j; > = > for (j =3D 0; j < e_RTE_METER_COLORS; j++) { > + /* if min/max are both zero, then RED is disabled */ > + if ((params->red_params[i][j].min_th | > + params->red_params[i][j].max_th) =3D=3D 0) { > + continue; > + } > + > if (rte_red_config_init(&port->red_config[i][j], > params->red_params[i][j].wq_log2, > params->red_params[i][j].min_th, > @@ -1069,6 +1075,9 @@ rte_sched_port_red_drop(struct rte_sched_port > *port, struct rte_mbuf *pkt, uint3 > color =3D rte_sched_port_pkt_read_color(pkt); > red_cfg =3D &port->red_config[tc_index][color]; > = > + if ( (red_cfg->min_th | red_cfg->max_th) =3D=3D 0) > + return 0; > + > qe =3D port->queue_extra + qindex; > red =3D &qe->red; > = > -- > 2.1.4 Acked by: Cristian Dumitrescu I agree with this approach of leaving RED as a library option that can be e= nabled/disabled at build-time in order to avoid any performance penalty whe= n RED is not required. On enqueue side (when RED is enabled): -Makes sense to avoid the RED processing when RED is not enabled for the cu= rrent queue; On dequeue side (when RED is enabled): -Not sure what's best when RED is not enabled for the current queue: whethe= r to go ahead anyway and apply the timestamp, as it is harmless (but might = trigger a cache miss) or check (which might trigger cache miss). Makes sens= e to go with the former option, which is implemented by this patch. -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others = is strictly prohibited. If you are not the intended recipient, please conta= ct the sender and delete all copies.