From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7B15DB789 for ; Fri, 20 Feb 2015 21:23:15 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 20 Feb 2015 12:23:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,616,1418112000"; d="scan'208";a="654978206" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga001.jf.intel.com with ESMTP; 20 Feb 2015 12:23:10 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by IRSMSX102.ger.corp.intel.com ([169.254.2.69]) with mapi id 14.03.0195.001; Fri, 20 Feb 2015 20:23:09 +0000 From: "Dumitrescu, Cristian" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read Thread-Index: AQHQQQsGJzFcjembK0CI5da80PrjtZzo8ijwgAACqoCAEP2yYIAAGQkAgAAGyDA= Date: Fri, 20 Feb 2015 20:23:08 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891263231B33C@IRSMSX108.ger.corp.intel.com> References: <1423116841-19799-4-git-send-email-stephen@networkplumber.org> <3EB4FA525960D640B5BDFFD6A3D89126323097BA@IRSMSX108.ger.corp.intel.com> <20150209145509.1b7bea9b@uryu.home.lan> <3EB4FA525960D640B5BDFFD6A3D891263231B296@IRSMSX108.ger.corp.intel.com> <20150220115256.7557e716@urahara> In-Reply-To: <20150220115256.7557e716@urahara> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 20:23:16 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, February 20, 2015 7:53 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics = when > read > = > On Fri, 20 Feb 2015 18:32:03 +0000 > "Dumitrescu, Cristian" wrote: > = > > Stephen, I suggest adding a new build-time configuration option for the > librte_sched library in config/common_* files: > CONFIG_RTE_SCHED_STATS_CLEAR_ON_READ. > = > Build time config options do not work for distributions. Why? This does not affect the API, as the new API functions are always compiled = in, and the prototypes are not changed, and no data structures are affected. This only changes the behavior of certain functions, so that user can selec= t which mode it needs. It also preserves backward compatibility. We have so many compilation options in config file, why is this one differe= nt? -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others = is strictly prohibited. If you are not the intended recipient, please conta= ct the sender and delete all copies.