From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C9809B789 for ; Fri, 20 Feb 2015 21:55:45 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 20 Feb 2015 12:50:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,616,1418112000"; d="scan'208";a="681057592" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 20 Feb 2015 12:55:41 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by IRSMSX102.ger.corp.intel.com ([169.254.2.69]) with mapi id 14.03.0195.001; Fri, 20 Feb 2015 20:55:41 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon , "imustafin@bk.ru" Thread-Topic: [dpdk-dev] RTE_PIPELINE_ACTION_PORT_META doesn't work properly Thread-Index: AQHQTU52CiNfNpPqVUyx8G5QrFWDNJz6BA0Q Date: Fri, 20 Feb 2015 20:55:40 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891263231B37B@IRSMSX108.ger.corp.intel.com> References: <1424449505.129655495@f327.i.mail.ru> <3EB4FA525960D640B5BDFFD6A3D891263231B304@IRSMSX108.ger.corp.intel.com> <10474963.UjXCaseS66@xps13> In-Reply-To: <10474963.UjXCaseS66@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] RTE_PIPELINE_ACTION_PORT_META doesn't work properly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 20:55:46 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, February 20, 2015 8:47 PM > To: Dumitrescu, Cristian; imustafin@bk.ru > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] RTE_PIPELINE_ACTION_PORT_META doesn't work > properly > = > 2015-02-20 19:26, Dumitrescu, Cristian: > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of ?????? > ???????? > > > Sent: Friday, February 20, 2015 4:25 PM > > > To: dev@dpdk.org > > > Subject: [dpdk-dev] RTE_PIPELINE_ACTION_PORT_META doesn't work > > > properly > > > > > > Hi, list! > > > > > > RTE_PIPELINE_ACTION_PORT_META option in rte_pipeline library > doesn't > > > work for non-default table entries. Is this bug or correct behaviour? > > > > > > This is my patch, that changes this behaviour: > > > > > > --- a/lib/librte_pipeline/rte_pipeline.c > > > +++ b/lib/librte_pipeline/rte_pipeline.c > > > @@ -999,8 +999,10 @@ rte_pipeline_compute_masks(struct > rte_pipeline > > > *p, uint64_t pkts_mask) > > > { > > > p->action_mask1[RTE_PIPELINE_ACTION_DROP] =3D 0; > > > p->action_mask1[RTE_PIPELINE_ACTION_PORT] =3D 0; > > > + p->action_mask1[RTE_PIPELINE_ACTION_PORT_META] =3D 0; > > > p->action_mask1[RTE_PIPELINE_ACTION_TABLE] =3D 0; > > > > > > + > > > if ((pkts_mask & (pkts_mask + 1)) =3D=3D 0) { > > > uint64_t n_pkts =3D __builtin_popcountll(pkts_mask); > > > uint32_t i; > > > @@ -1224,6 +1226,7 @@ rte_pipeline_run(struct rte_pipeline *p) > > > pkts_mask =3D RTE_LEN2MASK(n_pkts, uint64_t); > > > p->action_mask0[RTE_PIPELINE_ACTION_DROP] =3D 0; > > > p->action_mask0[RTE_PIPELINE_ACTION_PORT] =3D 0; > > > + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] =3D 0; > > > p->action_mask0[RTE_PIPELINE_ACTION_TABLE] =3D 0; > > > > > > /* Input port user actions */ > > > @@ -1300,6 +1303,9 @@ rte_pipeline_run(struct rte_pipeline *p) > > > p->action_mask0[RTE_PIPELINE_ACTION_P= ORT] |=3D > > > p->action_mask1[ > > > RTE_PIPELINE_ACTION_P= ORT]; > > > + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] |=3D > > > + p->action_mask1[ > > > + RTE_PIPELINE_ACTION_PORT_META]; > > > p->action_mask0[RTE_PIPELINE_ACTION_T= ABLE] |=3D > > > p->action_mask1[ > > > RTE_PIPELINE_ACTION_T= ABLE]; > > > > > > > > > > > > > > > > > > Thanks, Ildar > > > > Acked by: Cristian Dumitrescu > = > No Cristian, you cannot ack this patch, even if it fixes the problem. > The format is not OK: indent is wrong and it's not signed. > Please Ildar, check http://dpdk.org/dev#send to know how to submit a > patch. > = > > Thank you, Ildar! Sorry, Thomas. Ildar, please fix the signature (currently it the above signature is: On B= ehalf Of ??????) and the indentation and resubmit. Regards, Cristian -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others = is strictly prohibited. If you are not the intended recipient, please conta= ct the sender and delete all copies.