From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E03BFC34A for ; Tue, 19 May 2015 17:32:32 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 19 May 2015 08:32:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,458,1427785200"; d="scan'208";a="697205518" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga001.jf.intel.com with ESMTP; 19 May 2015 08:32:31 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.59]) by IRSMSX107.ger.corp.intel.com ([169.254.10.94]) with mapi id 14.03.0224.002; Tue, 19 May 2015 16:32:30 +0100 From: "Dumitrescu, Cristian" To: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/ip_pipeline: fix build with clang 3.6 Thread-Index: AQHQkh/vsqrGtize8kuxpfTakVbxFZ2DbXkQ Date: Tue, 19 May 2015 15:32:29 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D8912632369F33@IRSMSX108.ger.corp.intel.com> References: <1432031834-12042-1-git-send-email-thomas.monjalon@6wind.com> In-Reply-To: <1432031834-12042-1-git-send-email-thomas.monjalon@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix build with clang 3.6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2015 15:32:33 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, May 19, 2015 11:37 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] examples/ip_pipeline: fix build with clang 3.= 6 >=20 > This error is detected: > examples/ip_pipeline/cmdline.c:272:15: error: address of array > 'params->file_path' will always evaluate to 'true' > if (!params->file_path) { > ~~~~~~~~~^~~~~~~~~ >=20 > file_path is an array in a structure so it's unneeded to check it. >=20 > Signed-off-by: Thomas Monjalon > --- > examples/ip_pipeline/cmdline.c | 6 ------ > 1 file changed, 6 deletions(-) >=20 > diff --git a/examples/ip_pipeline/cmdline.c > b/examples/ip_pipeline/cmdline.c > index 152acb5..3173fd0 100644 > --- a/examples/ip_pipeline/cmdline.c > +++ b/examples/ip_pipeline/cmdline.c > @@ -268,12 +268,6 @@ cmd_run_file_parsed( > struct cmdline *file_cl; > int fd; >=20 > - /* Check params */ > - if (!params->file_path) { > - printf("Illegal value for file path (%s)\n", params->file_path); > - return; > - } > - > fd =3D open(params->file_path, O_RDONLY, 0); > if (fd < 0) { > printf("Illegal value for file path (%s)\n", params->file_path); > -- > 2.4.0 Acked-by: Cristian Dumitrescu