DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	"Gajdzica, MaciejX T" <maciejx.t.gajdzica@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 01/10] table: added structure for storing table stats
Date: Tue, 26 May 2015 21:40:42 +0000	[thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891263236CA8C@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20150526075754.791473f6@urahara>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Tuesday, May 26, 2015 3:58 PM
> To: Gajdzica, MaciejX T
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 01/10] table: added structure for storing
> table stats
> 
> On Tue, 26 May 2015 14:39:38 +0200
> Maciej Gajdzica <maciejx.t.gajdzica@intel.com> wrote:
> 
> > +
> >  /** Lookup table interface defining the lookup table operation */
> >  struct rte_table_ops {
> >  	rte_table_op_create f_create;       /**< Create */
> > @@ -194,6 +218,7 @@ struct rte_table_ops {
> >  	rte_table_op_entry_add f_add;       /**< Entry add */
> >  	rte_table_op_entry_delete f_delete; /**< Entry delete */
> >  	rte_table_op_lookup f_lookup;       /**< Lookup */
> > +	rte_table_op_stats_read f_stats;	/**< Stats */
> >  };
> 
> Another good idea, which is an ABI change.

This is simply adding a new API function, this is not changing any function prototype. There is no change required in the map file of this library. Is there anything we should have done and we did not do?

  reply	other threads:[~2015-05-26 21:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26 12:39 [dpdk-dev] [PATCH v3 00/10] table: added table statistics Maciej Gajdzica
2015-05-26 12:39 ` [dpdk-dev] [PATCH v3 01/10] table: added structure for storing table stats Maciej Gajdzica
2015-05-26 14:57   ` Stephen Hemminger
2015-05-26 21:40     ` Dumitrescu, Cristian [this message]
2015-05-26 21:57       ` Stephen Hemminger
2015-05-28 19:32         ` Dumitrescu, Cristian
2015-05-28 21:41           ` Stephen Hemminger
2015-05-26 22:03   ` Chris Wright
2015-05-26 12:39 ` [dpdk-dev] [PATCH v3 02/10] table: added acl " Maciej Gajdzica
2015-05-26 12:39 ` [dpdk-dev] [PATCH v3 03/10] table: added array " Maciej Gajdzica
2015-05-26 12:39 ` [dpdk-dev] [PATCH v3 04/10] table: added hash_ext " Maciej Gajdzica
2015-05-26 12:39 ` [dpdk-dev] [PATCH v3 05/10] table: added hash_key16 " Maciej Gajdzica
2015-05-26 12:39 ` [dpdk-dev] [PATCH v3 06/10] table: added hash_key32 " Maciej Gajdzica
2015-05-26 12:39 ` [dpdk-dev] [PATCH v3 07/10] table: added hash_key8 " Maciej Gajdzica
2015-05-26 12:39 ` [dpdk-dev] [PATCH v3 08/10] table: added hash_lru " Maciej Gajdzica
2015-05-26 12:39 ` [dpdk-dev] [PATCH v3 09/10] table: added lpm_ipv6 " Maciej Gajdzica
2015-05-26 12:39 ` [dpdk-dev] [PATCH v3 10/10] table: added lpm " Maciej Gajdzica
2015-05-26 13:39 ` [dpdk-dev] [PATCH v3 00/10] table: added table statistics Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EB4FA525960D640B5BDFFD6A3D891263236CA8C@IRSMSX108.ger.corp.intel.com \
    --to=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=maciejx.t.gajdzica@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).