From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5C5A2C34A for ; Thu, 28 May 2015 21:26:36 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 28 May 2015 12:26:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,513,1427785200"; d="scan'208";a="701746483" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga001.jf.intel.com with ESMTP; 28 May 2015 12:26:20 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.59]) by IRSMSX152.ger.corp.intel.com ([169.254.6.148]) with mapi id 14.03.0224.002; Thu, 28 May 2015 20:26:20 +0100 From: "Dumitrescu, Cristian" To: Rajagopalan Sivaramakrishnan , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline Thread-Index: AQHQmM652FttWDxm/02UWehTOpnofZ2RxAew Date: Thu, 28 May 2015 19:26:18 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891263236E6CA@IRSMSX108.ger.corp.intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 19:26:36 -0000 Hi Raja, Thanks for your input. I think we have the following options identified so far for stats collectio= n configuration: 1. Stats configuration through the RTE_LOG_LEVEL 2. Single configuration flag global for all DPDK libraries 3. Single configuration flag per DPDK library It would be good if Thomas and Stephen, as well as others, would reply with= their preference order. My personal preference order is: 3., 2., 1., but I can work with any of the= above that is identified by the majority of the replies. My goal right now= is reaching a conclusion on this item as soon as we can. Regards, Cristian > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rajagopalan > Sivaramakrishnan > Sent: Wednesday, May 27, 2015 11:45 PM > To: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pi= peline >=20 >=20 > > > You also reiterate that you would like to have the stats always enabl= ed. > You > > can definitely do this, it is one of the available choices, but why not= also > > accommodate the users that want to pick the opposite choice? Why force > > apps to spend cycles on stats if the app either does not want these > counters > > (library counters not relevant for that app, maybe the app is only > interested > > in maintaining some other stats that it implements itself) or do not wa= nt > > them anymore (maybe they only needed them during debug phase), etc? > > Jay asked this question, and I did my best in my reply to describe our > > motivation (http://www.dpdk.org/ml/archives/dev/2015- > May/017992.html). > > Maybe you missed that post, it would be good to get your reply on this = one > > too. > > > > I want to see DPDK get out of the config madness. > > This is real code, not an Intel benchmark special. >=20 >=20 > I agree that statistics will definitely be required in most real-world pr= oduction > environments and the overhead > from per-core stats gathering will be minimal if the data structures are = such > that CPU cache thrashing is avoided. > However, if there are scenarios where it is desirable to turn stats off, = I think > we can live with a config option. > I am not comfortable with using the log level to enable/disable statistic= s as > they are not really related. A > separate config option for stats collection seems like a reasonable > compromise. >=20 > Raja