Re: [dpdk-dev] [PATCH v6 05/11] ip_pipeline: added master pipeline

["Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>]

> -----Original Message-----
> From: Gajdzica, MaciejX T
> Sent: Thursday, July 9, 2015 12:58 PM
> To: Thomas Monjalon; Singh, Jasvinder
> Cc: dev@dpdk.org; Dumitrescu, Cristian
> Subject: RE: [dpdk-dev] [PATCH v6 05/11] ip_pipeline: added master pipeline
> 
> 
> 
> > -----Original Message-----
> > From: Gajdzica, MaciejX T
> > Sent: Thursday, July 09, 2015 10:03 AM
> > To: 'Thomas Monjalon'; Singh, Jasvinder
> > Cc: dev@dpdk.org; Dumitrescu, Cristian
> > Subject: RE: [dpdk-dev] [PATCH v6 05/11] ip_pipeline: added master
> pipeline
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > Sent: Thursday, July 09, 2015 12:33 AM
> > > To: Gajdzica, MaciejX T; Singh, Jasvinder
> > > Cc: dev@dpdk.org; Dumitrescu, Cristian
> > > Subject: Re: [dpdk-dev] [PATCH v6 05/11] ip_pipeline: added master
> > > pipeline
> > >
> > > 2015-07-07 10:09, Maciej Gajdzica:
> > > > From: Jasvinder Singh <jasvinder.singh@intel.com>
> > > >
> > > > Master pipeline is responsible for command line handling and
> > > > communicationg with all other pipelines via message queues. Removed
> > > > cmdline.c file, as its functionality will be split over multiple
> > > > pipeline files.
> > > >
> > > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > >
> > > In this v6, it builds well until patch 05 which uses some not exported
> symbols:
> > > pipeline_common_be.c:(.text+0x51): undefined reference to
> > > `rte_pipeline_port_in_stats_read'
> > > pipeline_common_be.c:(.text+0x91): undefined reference to
> > > `rte_pipeline_port_out_stats_read'
> > > pipeline_common_be.c:(.text+0xd4): undefined reference to
> > > `rte_pipeline_table_stats_read'
> > >
> > > Please check build with shared libraries.
> >
> > There are missing symbols in map file for librte_port and librte_pipeline. I
> will
> > send separate patch for that.
> 
> This compilation problem with shared libraries is not because something with
> this
> patchset is wrong, but because exported symbols in map file in earlier
> patchsets are
> missing. So after separate patches with fix will be applied, could you restore
> this patchset?
> 
> Best Regards
> Maciek

Hi Maciek, I suggest we add the missing symbols to the librte_port, lib_rte_table and librte_pipeline as a new patch; this should fix the v6 patch series on ip_pipeline without any need for v7? Thanks, Cristian