From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cristian.dumitrescu@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 8D4F8CF9
 for <dev@dpdk.org>; Thu, 16 Jul 2015 17:09:58 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga103.jf.intel.com with ESMTP; 16 Jul 2015 08:09:25 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,488,1432623600"; d="scan'208";a="607459670"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
 by orsmga003.jf.intel.com with ESMTP; 16 Jul 2015 08:09:18 -0700
Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by
 IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Thu, 16 Jul 2015 16:09:18 +0100
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.201]) by
 irsmsx112.ger.corp.intel.com ([169.254.1.163]) with mapi id 14.03.0224.002;
 Thu, 16 Jul 2015 16:09:17 +0100
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] doc: announce ABI change for librte_port
Thread-Index: AQHQv8KM0FK+pQNJsUGz/lBK9fqOap3eMwMQ
Date: Thu, 16 Jul 2015 15:09:16 +0000
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891263239D011@IRSMSX108.ger.corp.intel.com>
References: <1437049176-6866-1-git-send-email-cristian.dumitrescu@intel.com>
 <2522078.kODQ7Zxo1C@xps13>
In-Reply-To: <2522078.kODQ7Zxo1C@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for librte_port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jul 2015 15:09:59 -0000



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, July 16, 2015 1:26 PM
> To: Dumitrescu, Cristian
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for librte_port
>=20
> 2015-07-16 13:19, Cristian Dumitrescu:
> > +* librte_port (rte_port.h): Macros to access the packet meta-data stor=
ed
> within
> > +  the packet buffer will be adjusted to cover the packet mbuf structur=
e as
> well,
> > +  as currently they are able to access any packet buffer location exce=
pt the
> > +  packet mbuf structure. The consequence is that applications currentl=
y
> using
> > +  these macros will have to adjust the value of the offset parameter o=
f
> these
> > +  macros by increasing it with sizeof(struc rte_mbuf). The affected ma=
cros
> are:
> > +  RTE_MBUF_METADATA_UINT<8, 16, 32, 64>_PTR and
> > +  RTE_MBUF_METADATA_UINT<8, 16, 32, 64>. In terms of code changes,
> most likely
> > +  only the definition of RTE_MBUF_METADATA_UINT8_PTR macro will be
> changed from
> > +  ``(&((uint8_t *) &(mbuf)[1])[offset])`` to
> > +  ``(&((uint8_t *) (mbuf))[offset])``.
>=20
> Cristian,
> General comment: you are too verbose :)
> Specifically on this patch: same comment ;)

No problem, will simplify and resend. Thanks, Thomas.