From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0399D2A1A for ; Mon, 28 Sep 2015 22:04:44 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 28 Sep 2015 13:04:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,604,1437462000"; d="scan'208";a="814928583" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga002.jf.intel.com with ESMTP; 28 Sep 2015 13:04:42 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 28 Sep 2015 21:04:41 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.216]) by irsmsx112.ger.corp.intel.com ([169.254.1.176]) with mapi id 14.03.0248.002; Mon, 28 Sep 2015 21:04:41 +0100 From: "Dumitrescu, Cristian" To: Christoph Gysin , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual) Thread-Index: AQHQ+F/3/XnPfOim9UCfBFVHkTOns55SYJAA Date: Mon, 28 Sep 2015 20:04:40 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126478DA284@IRSMSX108.ger.corp.intel.com> References: <56069ea4.47ac700a.ca875.43bb@mx.google.com> In-Reply-To: <56069ea4.47ac700a.ca875.43bb@mx.google.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Sep 2015 20:04:45 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Christoph Gysin > Sent: Saturday, September 26, 2015 2:10 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual) >=20 > 'virtual' is a keyword and can't be used if the code is to compile with > C++ compilers. >=20 > If rte_devargs.h was included in C++ code, compilation with clang++ > failed with an error. g++ did not fail, but only because of a bug > that treats it as an anonymous struct with a decl-specifier which it > ignores. >=20 > This simply renames the member to 'virt'. > --- Acked-by: Cristian Dumitrescu David, Thomas, are you OK with this change? Thanks, Cristian