From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2DF8B6A87 for ; Thu, 1 Oct 2015 14:37:56 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 01 Oct 2015 05:37:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,617,1437462000"; d="scan'208";a="801362734" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga001.fm.intel.com with ESMTP; 01 Oct 2015 05:37:53 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.216]) by IRSMSX154.ger.corp.intel.com ([169.254.12.211]) with mapi id 14.03.0248.002; Thu, 1 Oct 2015 13:37:52 +0100 From: "Dumitrescu, Cristian" To: Neil Horman , "Singh, Jasvinder" Thread-Topic: [dpdk-dev] [PATCH v2] ip_pipeline: add more functions to routing-pipeline Thread-Index: AQHQ/DiMJ4Dm6R3e3E2JfBAf4y45sp5Wjmmg Date: Thu, 1 Oct 2015 12:37:51 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126478DC90B@IRSMSX108.ger.corp.intel.com> References: <3EB4FA525960D640B5BDFFD6A3D89126478DBD44@IRSMSX108.ger.corp.intel.com> <1443690315-28489-1-git-send-email-jasvinder.singh@intel.com> <20151001110049.GB4537@hmsreliant.think-freely.org> In-Reply-To: <20151001110049.GB4537@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] ip_pipeline: add more functions to routing-pipeline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2015 12:37:56 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Neil Horman > Sent: Thursday, October 1, 2015 12:01 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] ip_pipeline: add more functions to > routing-pipeline >=20 > > > > /* > > @@ -106,9 +164,7 @@ struct pipeline_routing_route_add_msg_req { > > struct pipeline_routing_route_key key; > > > > /* data */ > > - uint32_t flags; > > - uint32_t port_id; /* Output port ID */ > > - uint32_t ip; /* Next hop IP address (only valid for remote routes) */ > > + struct pipeline_routing_route_data data; > > }; > > >=20 > The example that you modifying appears to directly set the structure fiel= ds > that > you removing above. As such these appear to be ABI breaking changes and > need to > go through the ABI process >=20 > Neil Hi Neil, This patch only changes application code (in DPDK examples/ip_pipeline fold= er), it does not change any library code (in DPDK lib folder). There is no = ABI versioning required for the example applications, so I don't think the = ABI restrictions are applicable here. The pipelines in the ip_pipeline application are provided only as examples = to encourage people to create their own pipelines, and their implementation= is evolving as new features are added. They are intended to support only = a limited set of protocols and features; for example, in this case of the r= outing pipeline, there is no intention to have them support an exhaustive l= ist of routing protocols (as this would be virtually impossible). Therefore= , there is no plan to standardize them and make them library code, where th= e API/ABI preservation is required. The code where we are committed to keep the API compatibility and apply the= ABI change process rigorously is the library code (e.g. librte_port, librt= e_table, librte_pipeline) and we are consistently doing this. Thank you for your comment! Regards, Cristian