From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3B4BF8DA4 for ; Mon, 5 Oct 2015 11:44:42 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 05 Oct 2015 02:44:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,637,1437462000"; d="scan'208";a="803810300" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga001.fm.intel.com with ESMTP; 05 Oct 2015 02:44:41 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.216]) by IRSMSX152.ger.corp.intel.com ([169.254.6.126]) with mapi id 14.03.0248.002; Mon, 5 Oct 2015 10:44:39 +0100 From: "Dumitrescu, Cristian" To: Christoph Gysin , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual) Thread-Index: AQHQ+n+iwB4cYIccq0CNiIpxD8o5F55TATOAgAmtx/A= Date: Mon, 5 Oct 2015 09:44:38 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126478DE034@IRSMSX108.ger.corp.intel.com> References: <1443509581-27823-1-git-send-email-christoph.gysin@gmail.com> In-Reply-To: <1443509581-27823-1-git-send-email-christoph.gysin@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2015 09:44:42 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Christoph Gysin > Sent: Tuesday, September 29, 2015 7:53 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual) >=20 > 'virtual' is a keyword and can't be used if the code is to compile with > C++ compilers. >=20 > If rte_devargs.h was included in C++ code, compilation with clang++ > failed with an error. g++ did not fail, but only because of a bug > that treats it as an anonymous struct with a decl-specifier which it > ignores. >=20 > This simply renames the member to 'virt'. >=20 > Signed-off-by: Christoph Gysin > --- Acked-by: Cristian Dumitrescu Christoph, please also copy David Marchand for further updates of this patc= h, as David is the maintainer of this component. Whenever in doubt about th= e maintainer, you can check file MAINTAINERS from DPDK root folder. Regards, Cristian