From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 965732C57 for ; Wed, 30 Mar 2016 15:24:04 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 30 Mar 2016 06:24:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,416,1455004800"; d="scan'208";a="948022634" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 30 Mar 2016 06:24:02 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.13]) by IRSMSX104.ger.corp.intel.com ([169.254.5.87]) with mapi id 14.03.0248.002; Wed, 30 Mar 2016 14:24:01 +0100 From: "Dumitrescu, Cristian" To: Thomas Monjalon , "dev@dpdk.org" CC: "Singh, Jasvinder" , "Zhang, Roy Fan" , "Hunt, David" Thread-Topic: [dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2 Thread-Index: AQHRaIYLM4cIojdsNUOfQNZJxhP35p9yO+sA Importance: high X-Priority: 1 Date: Wed, 30 Mar 2016 13:24:01 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126479744E9@IRSMSX108.ger.corp.intel.com> References: <1455605170-16137-1-git-send-email-thomas.monjalon@6wind.com> <1455605170-16137-3-git-send-email-thomas.monjalon@6wind.com> In-Reply-To: <1455605170-16137-3-git-send-email-thomas.monjalon@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjNmY2YxOTItYjI5Ny00Zjk3LTlhNzMtMGRiNTUzNDcwOGU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InVvZHhFRjZsZDBaTzNwbm5zNlR2OEcyOWhBYW9QVDhSNzI4K2hPcUoreDg9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 13:24:05 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, February 16, 2016 6:46 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for > x86_64 without SSE4.2 >=20 > The compiler cannot use _mm_crc32_u64: >=20 > examples/ip_pipeline/pipeline/hash_func.h:165:9: > error: implicit declaration of function '_mm_crc32_u64' is invalid in C99 >=20 > Fixes: 947024a26df7 ("examples/ip_pipeline: rework passthrough pipeline") >=20 > Signed-off-by: Thomas Monjalon > --- > examples/ip_pipeline/pipeline/hash_func.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/examples/ip_pipeline/pipeline/hash_func.h > b/examples/ip_pipeline/pipeline/hash_func.h > index 7846300..1953ad4 100644 > --- a/examples/ip_pipeline/pipeline/hash_func.h > +++ b/examples/ip_pipeline/pipeline/hash_func.h > @@ -152,7 +152,7 @@ hash_xor_key64(void *key, __rte_unused uint32_t > key_size, uint64_t seed) > return (xor0 >> 32) ^ xor0; > } >=20 > -#if defined(__x86_64__) > +#if defined(__x86_64__) && defined(RTE_CPUFLAG_SSE4_2) >=20 > #include >=20 > -- > 2.7.0 Hi Thomas, This is not the correct fix, as RTE_CPUFLAG_SSE4_2 is a flag that can only = be tested at run-time (as result of calling function rte_cpu_get_flag_enabl= ed()), not at build-time. The reason it appears to fix the build issue you are mentioning is the fact= that this change results in disabling the __x86_64__ code branch. We need to revert this patch and look for a better option. What is the compiler that generates the build issue you are mentioning? We = could not reproduce it with gcc 5 (gcc 5.3.1). Thanks, Cristian