From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D4E7FADB7 for ; Tue, 10 May 2016 19:18:08 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 10 May 2016 10:18:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,605,1455004800"; d="scan'208";a="803206396" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga003.jf.intel.com with ESMTP; 10 May 2016 10:18:07 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.241]) by IRSMSX101.ger.corp.intel.com ([169.254.1.19]) with mapi id 14.03.0248.002; Tue, 10 May 2016 18:18:06 +0100 From: "Dumitrescu, Cristian" To: "Mrzyglod, DanielX T" CC: "dev@dpdk.org" Thread-Topic: [PATCH] sched: fix useless call Thread-Index: AQHRqpvyfD6Vaw5fXEq6A+nryz5g2J+yadbw Date: Tue, 10 May 2016 17:18:06 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126479BAF1D@IRSMSX108.ger.corp.intel.com> References: <1462875064-119474-1-git-send-email-danielx.t.mrzyglod@intel.com> In-Reply-To: <1462875064-119474-1-git-send-email-danielx.t.mrzyglod@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2JhZjA5YzItYmI1YS00NzlmLTgyNDgtMzhlY2UyNjZiMjIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjJvaklvV2VmcHVlK3RtbVdDd082NmtIVSt5dmo0UW1SdmhvZ3J6QXdRekU9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] sched: fix useless call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2016 17:18:09 -0000 > -----Original Message----- > From: Mrzyglod, DanielX T > Sent: Tuesday, May 10, 2016 11:11 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [PATCH] sched: fix useless call >=20 > Fix issue reported by Coverity. > Coverity ID 13338 >=20 > A function call that seems to have an intended effect has no actual effec= t > on the logic of the program. >=20 > In rte_sched_port_free: A function is called that is only useful for its > return value, and this value is ignored. >=20 > Fixes: de3cfa2c9823 ("sched: initial import") >=20 > Signed-off-by: Daniel Mrzyglod > --- > lib/librte_sched/rte_sched.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c > index 1609ea8..9b962a6 100644 > --- a/lib/librte_sched/rte_sched.c > +++ b/lib/librte_sched/rte_sched.c > @@ -749,7 +749,6 @@ rte_sched_port_free(struct rte_sched_port *port) > rte_pktmbuf_free(mbufs[i]); > } >=20 > - rte_bitmap_free(port->bmp); > rte_free(port); > } >=20 > -- > 2.5.5 NAK. This needs to be flagged out as a false positive to Coverity. As previously discussed on this email list, the rte_bitmap_free() is an API= function that works as a placeholder for any resource freeing that needs t= o be done for the bitmap. The API function should not be removed and also t= he call to this function from the rte_sched_port_free() should not be remov= ed either. Thanks, Cristian