From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 326C46A67 for ; Thu, 12 May 2016 11:41:03 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 12 May 2016 02:41:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,609,1455004800"; d="scan'208";a="101855749" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga004.fm.intel.com with ESMTP; 12 May 2016 02:41:01 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.241]) by IRSMSX109.ger.corp.intel.com ([169.254.13.120]) with mapi id 14.03.0248.002; Thu, 12 May 2016 10:41:00 +0100 From: "Dumitrescu, Cristian" To: "Mrozowicz, SlawomirX" CC: "dev@dpdk.org" , "Singh, Jasvinder" Thread-Topic: [PATCH v3] examples/qos_meter: fix unchecked return value Thread-Index: AQHRqc3Dqdf3hfvick+74c7JV/MfwZ+yYhcAgAERoACAAITyAIAA4IxwgAA31wA= Date: Thu, 12 May 2016 09:40:59 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126479BBB6D@IRSMSX108.ger.corp.intel.com> References: <1462783091-2538-1-git-send-email-slawomirx.mrozowicz@intel.com> <3EB4FA525960D640B5BDFFD6A3D89126479BAFA7@IRSMSX108.ger.corp.intel.com> <158888A50F43E34AAE179517F56C97455A4884@IRSMSX103.ger.corp.intel.com> <3EB4FA525960D640B5BDFFD6A3D89126479BB842@IRSMSX108.ger.corp.intel.com> <158888A50F43E34AAE179517F56C97455A49EE@IRSMSX103.ger.corp.intel.com> In-Reply-To: <158888A50F43E34AAE179517F56C97455A49EE@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzdjZDZkOWUtZjNlMC00M2ViLTk1MDgtNzY4OTQxYjYwNmYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjBZOGlsTExhbExobjVXM200cG9YeDFMWUxTNERiNEdkSVZXMFp2MDhKc3M9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] examples/qos_meter: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2016 09:41:03 -0000 > -----Original Message----- > From: Mrozowicz, SlawomirX > Sent: Thursday, May 12, 2016 8:06 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Singh, Jasvinder > Subject: RE: [PATCH v3] examples/qos_meter: fix unchecked return value >=20 >=20 >=20 > >-----Original Message----- > >From: Dumitrescu, Cristian > >Sent: Wednesday, May 11, 2016 7:57 PM > >To: Mrozowicz, SlawomirX > >Cc: dev@dpdk.org; Singh, Jasvinder > >Subject: RE: [PATCH v3] examples/qos_meter: fix unchecked return value > > > > > > > >> -----Original Message----- > >> From: Mrozowicz, SlawomirX > >> Sent: Wednesday, May 11, 2016 10:15 AM > >> To: Dumitrescu, Cristian > >> Cc: dev@dpdk.org; Singh, Jasvinder > >> Subject: RE: [PATCH v3] examples/qos_meter: fix unchecked return value > >> > >> > >> > >> >-----Original Message----- > >> >From: Dumitrescu, Cristian > >> >Sent: Tuesday, May 10, 2016 7:42 PM > >> >To: Mrozowicz, SlawomirX > >> >Cc: dev@dpdk.org; Singh, Jasvinder > >> >Subject: RE: [PATCH v3] examples/qos_meter: fix unchecked return > >> >value > >> > > >> > > >> > > >> >> -----Original Message----- > >> >> From: Mrozowicz, SlawomirX > >> >> Sent: Monday, May 9, 2016 9:38 AM > >> >> To: Dumitrescu, Cristian > >> >> Cc: dev@dpdk.org; Singh, Jasvinder ; > >> >> Mrozowicz, SlawomirX > >> >> Subject: [PATCH v3] examples/qos_meter: fix unchecked return value > >> >> > >> >> Fix issue reported by Coverity. > >> >> > >> >> Coverity ID 30693: Unchecked return value > >> >> check_return: Calling rte_meter_srtcm_config without checking > >> >> return value. > >> >> > >> >> Fixes: e6541fdec8b2 ("meter: initial import") > >> >> > >> >> Signed-off-by: Slawomir Mrozowicz > > >> >> --- > >> >> examples/qos_meter/main.c | 15 ++++++++++----- > >> >> examples/qos_meter/main.h | 2 +- > >> >> 2 files changed, 11 insertions(+), 6 deletions(-) > >> >> > >> >> diff --git a/examples/qos_meter/main.c > b/examples/qos_meter/main.c > >> >> index b968b00..7c69606 100644 > >> >> --- a/examples/qos_meter/main.c > >> >> +++ b/examples/qos_meter/main.c > >> >> @@ -133,14 +133,17 @@ struct rte_meter_trtcm_params > >> >app_trtcm_params[] > >> >> =3D { > >> >> > >> >> FLOW_METER app_flows[APP_FLOWS_MAX]; > >> >> > >> >> -static void > >> >> +static int > >> >> app_configure_flow_table(void) > >> >> { > >> >> uint32_t i, j; > >> >> + int ret =3D 0; > >> >> > >> >> - for (i =3D 0, j =3D 0; i < APP_FLOWS_MAX; i ++, j =3D (j + 1) % > >> >> RTE_DIM(PARAMS)){ > >> >> - FUNC_CONFIG(&app_flows[i], &PARAMS[j]); > >> >> - } > >> >> + for (i =3D 0, j =3D 0; i < APP_FLOWS_MAX && ret =3D=3D 0; > >> >> + i ++, j =3D (j + 1) % RTE_DIM(PARAMS)) > >> >> + ret =3D FUNC_CONFIG(&app_flows[i], &PARAMS[j]); > >> >> + > >> >> + return ret; > >> >> } > >> > > >> >This is only returns the configuration status for the last flow and > >> >leaves undetected an error for any other flow. Why not check the > >> >status for each flow and return an error on first occurrence? > >> >For (...){ret =3D FUNC_CONFIG(...); if (ret) return ret;} > >> > > >> > >> This code check status of the function FUNC_CONFIG for each flow and > >> return an error on first occurrence. Rest of functions FUNC_CONFIG are > >> not called. See terminate condition of the loop. > >> > > > >Where is the status of FUNC_CONFIG checked exactly? I cannot see any > check > >in your code. I can only see returning the status code for the last call= of this > >function in the for loop. I was expecting a check such as: if (ret) retu= rn ret. > > >=20 > Look at the loop terminate conditions: > i < APP_FLOWS_MAX && ret =3D=3D 0 > Program terminate the loop if the ret variable is differ then zero. > It means that program terminate if the last status of FUNC_CONFIG is an > error. Yes, you're right, my bad, sorry. >=20 > >> >> > >> >> static inline void > >> >> @@ -381,7 +384,9 @@ main(int argc, char **argv) > >> >> rte_eth_promiscuous_enable(port_tx); > >> >> > >> >> /* App configuration */ > >> >> - app_configure_flow_table(); > >> >> + ret =3D app_configure_flow_table(); > >> >> + if (ret < 0) > >> >> + rte_exit(EXIT_FAILURE, "Invalid configure flow table\n"); > >> >> > >> >> /* Launch per-lcore init on every lcore */ > >> >> rte_eal_mp_remote_launch(main_loop, NULL, CALL_MASTER); diff - > >> - > >> >git > >> >> a/examples/qos_meter/main.h b/examples/qos_meter/main.h index > >> >> 530bf69..54867dc 100644 > >> >> --- a/examples/qos_meter/main.h > >> >> +++ b/examples/qos_meter/main.h > >> >> @@ -51,7 +51,7 @@ enum policer_action > >> >> policer_table[e_RTE_METER_COLORS][e_RTE_METER_COLORS] =3D #if > >> >APP_MODE > >> >> =3D=3D APP_MODE_FWD > >> >> > >> >> #define FUNC_METER(a,b,c,d) color, flow_id=3Dflow_id, > >> >> pkt_len=3Dpkt_len, time=3Dtime -#define FUNC_CONFIG(a,b) > >> >> +#define FUNC_CONFIG(a, b) 0 > >> >> #define PARAMS app_srtcm_params > >> >> #define FLOW_METER int > >> >> > >> >> -- > >> >> 1.9.1