* [dpdk-dev] [PATCH] examples/ip_pipline: fix memory initialization in firewall bulk functions
@ 2016-05-06 17:54 Daniel Mrzyglod
2016-05-13 9:36 ` Dumitrescu, Cristian
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Mrzyglod @ 2016-05-06 17:54 UTC (permalink / raw)
To: marcinx.kerlin, cristian.dumitrescu, jasvinder.singh; +Cc: dev, Daniel Mrzyglod
bulk functions expect that all memory is set with zeros
Fixes: 67ebdbef0c31 ("examples/ip_pipeline: add bulk update of firewall rules")
Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
examples/ip_pipeline/pipeline/pipeline_firewall_be.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/examples/ip_pipeline/pipeline/pipeline_firewall_be.c b/examples/ip_pipeline/pipeline/pipeline_firewall_be.c
index e7a8a4c..4edca66 100644
--- a/examples/ip_pipeline/pipeline/pipeline_firewall_be.c
+++ b/examples/ip_pipeline/pipeline/pipeline_firewall_be.c
@@ -732,7 +732,7 @@ pipeline_firewall_msg_req_add_bulk_handler(struct pipeline *p, void *msg)
n_keys = req->n_keys;
for (i = 0; i < n_keys; i++) {
- entries[i] = rte_malloc(NULL,
+ entries[i] = rte_zmalloc(NULL,
sizeof(struct firewall_table_entry),
RTE_CACHE_LINE_SIZE);
if (entries[i] == NULL) {
@@ -740,7 +740,7 @@ pipeline_firewall_msg_req_add_bulk_handler(struct pipeline *p, void *msg)
return rsp;
}
- params[i] = rte_malloc(NULL,
+ params[i] = rte_zmalloc(NULL,
sizeof(struct rte_table_acl_rule_add_params),
RTE_CACHE_LINE_SIZE);
if (params[i] == NULL) {
@@ -814,7 +814,7 @@ pipeline_firewall_msg_req_del_bulk_handler(struct pipeline *p, void *msg)
n_keys = req->n_keys;
for (i = 0; i < n_keys; i++) {
- params[i] = rte_malloc(NULL,
+ params[i] = rte_zmalloc(NULL,
sizeof(struct rte_table_acl_rule_delete_params),
RTE_CACHE_LINE_SIZE);
if (params[i] == NULL) {
--
2.5.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ip_pipline: fix memory initialization in firewall bulk functions
2016-05-06 17:54 [dpdk-dev] [PATCH] examples/ip_pipline: fix memory initialization in firewall bulk functions Daniel Mrzyglod
@ 2016-05-13 9:36 ` Dumitrescu, Cristian
2016-05-16 18:18 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Dumitrescu, Cristian @ 2016-05-13 9:36 UTC (permalink / raw)
To: Mrzyglod, DanielX T, Kerlin, MarcinX, Singh, Jasvinder; +Cc: dev
> -----Original Message-----
> From: Mrzyglod, DanielX T
> Sent: Friday, May 6, 2016 6:55 PM
> To: Kerlin, MarcinX <marcinx.kerlin@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Cc: dev@dpdk.org; Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>
> Subject: [PATCH] examples/ip_pipline: fix memory initialization in firewall
> bulk functions
>
> bulk functions expect that all memory is set with zeros
>
> Fixes: 67ebdbef0c31 ("examples/ip_pipeline: add bulk update of firewall
> rules")
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
> examples/ip_pipeline/pipeline/pipeline_firewall_be.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/examples/ip_pipeline/pipeline/pipeline_firewall_be.c
> b/examples/ip_pipeline/pipeline/pipeline_firewall_be.c
> index e7a8a4c..4edca66 100644
> --- a/examples/ip_pipeline/pipeline/pipeline_firewall_be.c
> +++ b/examples/ip_pipeline/pipeline/pipeline_firewall_be.c
> @@ -732,7 +732,7 @@ pipeline_firewall_msg_req_add_bulk_handler(struct
> pipeline *p, void *msg)
> n_keys = req->n_keys;
>
> for (i = 0; i < n_keys; i++) {
> - entries[i] = rte_malloc(NULL,
> + entries[i] = rte_zmalloc(NULL,
> sizeof(struct firewall_table_entry),
> RTE_CACHE_LINE_SIZE);
> if (entries[i] == NULL) {
> @@ -740,7 +740,7 @@ pipeline_firewall_msg_req_add_bulk_handler(struct
> pipeline *p, void *msg)
> return rsp;
> }
>
> - params[i] = rte_malloc(NULL,
> + params[i] = rte_zmalloc(NULL,
> sizeof(struct
> rte_table_acl_rule_add_params),
> RTE_CACHE_LINE_SIZE);
> if (params[i] == NULL) {
> @@ -814,7 +814,7 @@ pipeline_firewall_msg_req_del_bulk_handler(struct
> pipeline *p, void *msg)
> n_keys = req->n_keys;
>
> for (i = 0; i < n_keys; i++) {
> - params[i] = rte_malloc(NULL,
> + params[i] = rte_zmalloc(NULL,
> sizeof(struct
> rte_table_acl_rule_delete_params),
> RTE_CACHE_LINE_SIZE);
> if (params[i] == NULL) {
> --
> 2.5.5
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ip_pipline: fix memory initialization in firewall bulk functions
2016-05-13 9:36 ` Dumitrescu, Cristian
@ 2016-05-16 18:18 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-05-16 18:18 UTC (permalink / raw)
To: Mrzyglod, DanielX T
Cc: dev, Dumitrescu, Cristian, Kerlin, MarcinX, Singh, Jasvinder
> > bulk functions expect that all memory is set with zeros
> >
> > Fixes: 67ebdbef0c31 ("examples/ip_pipeline: add bulk update of firewall
> > rules")
> >
> > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-16 18:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-06 17:54 [dpdk-dev] [PATCH] examples/ip_pipline: fix memory initialization in firewall bulk functions Daniel Mrzyglod
2016-05-13 9:36 ` Dumitrescu, Cristian
2016-05-16 18:18 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).