From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 937C295E9 for ; Fri, 13 May 2016 11:36:07 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 13 May 2016 02:36:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,613,1455004800"; d="scan'208";a="102548486" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga004.fm.intel.com with ESMTP; 13 May 2016 02:36:05 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.241]) by IRSMSX109.ger.corp.intel.com ([169.254.13.120]) with mapi id 14.03.0248.002; Fri, 13 May 2016 10:36:05 +0100 From: "Dumitrescu, Cristian" To: "Mrzyglod, DanielX T" , "Kerlin, MarcinX" , "Singh, Jasvinder" CC: "dev@dpdk.org" Thread-Topic: [PATCH] examples/ip_pipline: fix memory initialization in firewall bulk functions Thread-Index: AQHRp7euTE6z9lexb0q0eB0Dv3bYKZ+2piKw Date: Fri, 13 May 2016 09:36:04 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126479BD3C3@IRSMSX108.ger.corp.intel.com> References: <1462557284-213903-1-git-send-email-danielx.t.mrzyglod@intel.com> In-Reply-To: <1462557284-213903-1-git-send-email-danielx.t.mrzyglod@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGVmZjc4NmUtMjJiNy00MGE1LTk4NzgtMTUxMTRjODg2YmQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InhGaVwvaTV4U2FHN0ZoMXYzdEF4XC9OblRLMmsyeHpRQXFnR3BpdUw3djVSVT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipline: fix memory initialization in firewall bulk functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2016 09:36:08 -0000 > -----Original Message----- > From: Mrzyglod, DanielX T > Sent: Friday, May 6, 2016 6:55 PM > To: Kerlin, MarcinX ; Dumitrescu, Cristian > ; Singh, Jasvinder > > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [PATCH] examples/ip_pipline: fix memory initialization in firewa= ll > bulk functions >=20 > bulk functions expect that all memory is set with zeros >=20 > Fixes: 67ebdbef0c31 ("examples/ip_pipeline: add bulk update of firewall > rules") >=20 > Signed-off-by: Daniel Mrzyglod > --- > examples/ip_pipeline/pipeline/pipeline_firewall_be.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/examples/ip_pipeline/pipeline/pipeline_firewall_be.c > b/examples/ip_pipeline/pipeline/pipeline_firewall_be.c > index e7a8a4c..4edca66 100644 > --- a/examples/ip_pipeline/pipeline/pipeline_firewall_be.c > +++ b/examples/ip_pipeline/pipeline/pipeline_firewall_be.c > @@ -732,7 +732,7 @@ pipeline_firewall_msg_req_add_bulk_handler(struct > pipeline *p, void *msg) > n_keys =3D req->n_keys; >=20 > for (i =3D 0; i < n_keys; i++) { > - entries[i] =3D rte_malloc(NULL, > + entries[i] =3D rte_zmalloc(NULL, > sizeof(struct firewall_table_entry), > RTE_CACHE_LINE_SIZE); > if (entries[i] =3D=3D NULL) { > @@ -740,7 +740,7 @@ pipeline_firewall_msg_req_add_bulk_handler(struct > pipeline *p, void *msg) > return rsp; > } >=20 > - params[i] =3D rte_malloc(NULL, > + params[i] =3D rte_zmalloc(NULL, > sizeof(struct > rte_table_acl_rule_add_params), > RTE_CACHE_LINE_SIZE); > if (params[i] =3D=3D NULL) { > @@ -814,7 +814,7 @@ pipeline_firewall_msg_req_del_bulk_handler(struct > pipeline *p, void *msg) > n_keys =3D req->n_keys; >=20 > for (i =3D 0; i < n_keys; i++) { > - params[i] =3D rte_malloc(NULL, > + params[i] =3D rte_zmalloc(NULL, > sizeof(struct > rte_table_acl_rule_delete_params), > RTE_CACHE_LINE_SIZE); > if (params[i] =3D=3D NULL) { > -- > 2.5.5 Acked-by: Cristian Dumitrescu