From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5DC3DADCE for ; Tue, 21 Jun 2016 12:01:31 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 21 Jun 2016 03:01:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,503,1459839600"; d="scan'208";a="722755814" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by FMSMGA003.fm.intel.com with ESMTP; 21 Jun 2016 03:01:23 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by IRSMSX109.ger.corp.intel.com ([169.254.13.193]) with mapi id 14.03.0248.002; Tue, 21 Jun 2016 11:01:21 +0100 From: "Dumitrescu, Cristian" To: Panu Matilainen , "dev@dpdk.org" CC: "christian.ehrhardt@canonical.com" , "thomas.monjalon@6wind.com" Thread-Topic: [dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline dependency list truncation Thread-Index: AQHRy5S26ur6n9uyZEeApM6naI7pSJ/zrMlQ Date: Tue, 21 Jun 2016 10:01:21 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D8912647A0A645@IRSMSX108.ger.corp.intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTI3N2JmZGYtNDFkNi00NGI3LTk4MDctZWE1NWU3NjYyYjg3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im9PUExaNzU4aHpCZXJSRmJobzlpc3VkTFJ5MmJnMzliRHNzaDN2XC9VMjVBPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline dependency list truncation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 10:01:31 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen > Sent: Tuesday, June 21, 2016 9:12 AM > To: dev@dpdk.org > Cc: christian.ehrhardt@canonical.com; thomas.monjalon@6wind.com > Subject: [dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline dependency list > truncation >=20 > In other libraries, dependency list is always appended to, but > in commit 6cbf4f75e059 it with an assignment. This causes the > librte_eal dependency added in commit 6cbf4f75e059 to get discarded, > resulting in missing dependency on librte_eal. >=20 > Fixes: b3688bee81a8 ("pipeline: new packet framework logic") > Fixes: 6cbf4f75e059 ("mk: fix missing internal dependencies") >=20 > Signed-off-by: Panu Matilainen > --- > lib/librte_pipeline/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_pipeline/Makefile b/lib/librte_pipeline/Makefile > index 95387aa..a8f3128 100644 > --- a/lib/librte_pipeline/Makefile > +++ b/lib/librte_pipeline/Makefile > @@ -53,7 +53,7 @@ SYMLINK-$(CONFIG_RTE_LIBRTE_PIPELINE)-include +=3D > rte_pipeline.h >=20 > # this lib depends upon: > DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) +=3D lib/librte_eal > -DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) :=3D lib/librte_table > +DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) +=3D lib/librte_table > DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) +=3D lib/librte_port >=20 > include $(RTE_SDK)/mk/rte.lib.mk > -- > 2.5.5 In release 16.4, EAL was missing from the dependency list, now it is added.= The librte_pipeline uses rte_malloc, therefore it depends on librte_eal be= ing present. In the Makefile of the other Packet Framework libraries (librte_port, librt= e_table), it looks like the first dependency in the list is EAL, which is l= isted with the assignment operator, followed by others that are listed with= the append operator: DEPDIRS-$(CONFIG_RTE_LIBRTE_XYZ) :=3D lib/librte_eal DEPDIRS-$(CONFIG_RTE_LIBRTE_XYZ) +=3D lib/librte_some other lib Therefore, at least for cosmetic reasons, we should probably do the same in= librte_pipeline, which requires changing both the librte_eal and the librt= e_table lines as below: DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) :=3D lib/librte_eal DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) +=3D lib/librte_table DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) +=3D lib/librte_port However, some other libraries e.g. librte_lpm simply add the EAL dependency= using the append operator: DEPDIRS-$(CONFIG_RTE_LIBRTE_LPM) +=3D lib/librte_eal To be honest, I need to refresh my knowledge on make, I don't remember righ= t now when we should use the assignment and when the append. Do we need to = use the assign for first dependency (EAL) and append for others or should w= e use append everywhere? Thanks, Cristian