From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Kobylinski, MichalX" <michalx.kobylinski@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] lib/table: fix wrong type of nht field
Date: Tue, 21 Jun 2016 13:21:58 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D8912647A0AB6D@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <5354419.Iiu9mVHfAO@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, June 21, 2016 2:16 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Kobylinski,
> MichalX <michalx.kobylinski@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] lib/table: fix wrong type of nht field
>
> > > Change type of nht field from uint32_t to uint8_t and increase max of
> > > next hops.
> > >
> > > Fixes: dc81ebbacaeb ("lpm: extend IPv4 next hop field")
> > > Signed-off-by: Michal Kobylinski <michalx.kobylinski@intel.com>
> > > ---
> > > v2:
> > > - removed changing from file: pipeline_routing_be.h
> > > - changed macro: RTE_TABLE_LPM_MAX_NEXT_HOP
> >
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>
> Cristian, the explanation is still missing in this commit.
Yes, you're right, sorry.
Michal K, please send updated version with the explanation and my ack included, thank you!
Regards,
Cristian
next prev parent reply other threads:[~2016-06-21 13:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 10:10 [dpdk-dev] [PATCH] " Michal Jastrzebski
2016-06-20 10:13 ` Thomas Monjalon
2016-06-21 11:16 ` Dumitrescu, Cristian
2016-06-21 11:20 ` Dumitrescu, Cristian
2016-06-21 12:27 ` [dpdk-dev] [PATCH v2] " Michal Kobylinski
2016-06-21 13:09 ` Dumitrescu, Cristian
2016-06-21 13:15 ` Thomas Monjalon
2016-06-21 13:21 ` Dumitrescu, Cristian [this message]
2016-06-21 13:20 ` [dpdk-dev] [PATCH v3] " Michal Kobylinski
2016-06-21 20:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D8912647A0AB6D@IRSMSX108.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=michalx.kobylinski@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).