From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6FC0BC434 for ; Tue, 21 Jun 2016 19:43:59 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 21 Jun 2016 10:43:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,505,1459839600"; d="scan'208";a="722945887" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by FMSMGA003.fm.intel.com with ESMTP; 21 Jun 2016 10:43:57 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by IRSMSX106.ger.corp.intel.com ([169.254.8.145]) with mapi id 14.03.0248.002; Tue, 21 Jun 2016 18:43:56 +0100 From: "Dumitrescu, Cristian" To: "Mrzyglod, DanielX T" , "Singh, Jasvinder" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8 Thread-Index: AQHRy5d7fML4uHeHCk+qDKQeRCMhlZ/0MTbw Date: Tue, 21 Jun 2016 17:43:55 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D8912647A0AE66@IRSMSX108.ger.corp.intel.com> References: <1465472328-226671-1-git-send-email-danielx.t.mrzyglod@intel.com> <1466501740-28237-1-git-send-email-danielx.t.mrzyglod@intel.com> In-Reply-To: <1466501740-28237-1-git-send-email-danielx.t.mrzyglod@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWEwZmM4M2EtNmU1Mi00MDI4LWFhNzQtZjlmMWE3MjlmOWMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InRudVBuZVU2bGZ1bUZtZzZ5WHp2SSt1QUdKZlFFOVJVSWFnd3RmRjJzbFk9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 17:44:00 -0000 > -----Original Message----- > From: Mrzyglod, DanielX T > Sent: Tuesday, June 21, 2016 10:36 AM > To: Singh, Jasvinder ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8 >=20 > This patch fixes a maybe-uninitialized warning when compiling DPDK with > GCC 4.8 >=20 > examples/ip_pipeline/pipeline/pipeline_common_fe.c: In function > 'app_pipeline_track_pktq_out_to_link': > examples/ip_pipeline/pipeline/pipeline_common_fe.c:66:31: error: > 'reader' may be used uninitialized in this function [-Werror=3Dmaybe- > uninitialized] >=20 > struct app_pktq_out_params *pktq_out =3D >=20 > Fixes: 760064838ec0 ("examples/ip_pipeline: link routing output ports to > devices") >=20 > Signed-off-by: Daniel Mrzyglod > Acked-by: Cristian Dumitrescu > --- > examples/ip_pipeline/app.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/app.h > index 7611341..242dae8 100644 > --- a/examples/ip_pipeline/app.h > +++ b/examples/ip_pipeline/app.h > @@ -667,11 +667,11 @@ app_swq_get_reader(struct app_params *app, > struct app_pktq_swq_params *swq, > uint32_t *pktq_in_id) > { > - struct app_pipeline_params *reader; > + struct app_pipeline_params *reader =3D NULL; > uint32_t pos =3D swq - app->swq_params; > uint32_t n_pipelines =3D RTE_MIN(app->n_pipelines, > RTE_DIM(app->pipeline_params)); > - uint32_t n_readers =3D 0, id, i; > + uint32_t n_readers =3D 0, id =3D 0, i; >=20 > for (i =3D 0; i < n_pipelines; i++) { > struct app_pipeline_params *p =3D &app->pipeline_params[i]; > @@ -727,11 +727,11 @@ app_tm_get_reader(struct app_params *app, > struct app_pktq_tm_params *tm, > uint32_t *pktq_in_id) > { > - struct app_pipeline_params *reader; > + struct app_pipeline_params *reader =3D NULL; > uint32_t pos =3D tm - app->tm_params; > uint32_t n_pipelines =3D RTE_MIN(app->n_pipelines, > RTE_DIM(app->pipeline_params)); > - uint32_t n_readers =3D 0, id, i; > + uint32_t n_readers =3D 0, id =3D 0, i; >=20 > for (i =3D 0; i < n_pipelines; i++) { > struct app_pipeline_params *p =3D &app->pipeline_params[i]; > -- > 2.5.5 No need for this patch, as these fixes have been already applied by Ethan's= patch.=20 Daniel, please check and let us know if otherwise.