From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Jan Blunck <jblunck@infradead.org>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "h.mikita89@gmail.com" <h.mikita89@gmail.com>,
Alan Dewar <adewar@brocade.com>
Subject: Re: [dpdk-dev] [PATCH] sched: fix segmentation fault when freeing port
Date: Mon, 6 Feb 2017 18:42:22 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D8912652748706@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1486402362-15098-1-git-send-email-jblunck@infradead.org>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jan Blunck
> Sent: Monday, February 6, 2017 5:33 PM
> To: dev@dpdk.org
> Cc: h.mikita89@gmail.com; Alan Dewar <adewar@brocade.com>
> Subject: [dpdk-dev] [PATCH] sched: fix segmentation fault when freeing port
>
> From: Alan Dewar <adewar@brocade.com>
>
> Prevent a segmentation fault in rte_sched_port_free by only accessing
> the port structure after the NULL pointer check has been made.
>
> Fixes: 7b3c4f35 ("sched: fix releasing enqueued packets")
>
> Signed-off-by: Alan Dewar <adewar@brocade.com>
> Signed-off-by: Jan Blunck <jblunck@infradead.org>
> ---
> lib/librte_sched/rte_sched.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
> index e6dace2..614705d 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -735,12 +735,14 @@ void
> rte_sched_port_free(struct rte_sched_port *port)
> {
> uint32_t qindex;
> - uint32_t n_queues_per_port =
> rte_sched_port_queues_per_port(port);
> + uint32_t n_queues_per_port;
>
> /* Check user parameters */
> if (port == NULL)
> return;
>
> + n_queues_per_port = rte_sched_port_queues_per_port(port);
> +
> /* Free enqueued mbufs */
> for (qindex = 0; qindex < n_queues_per_port; qindex++) {
> struct rte_mbuf **mbufs = rte_sched_port_qbase(port,
> qindex);
> --
> 2.7.4
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
next prev parent reply other threads:[~2017-02-06 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 17:32 Jan Blunck
2017-02-06 18:42 ` Dumitrescu, Cristian [this message]
2017-02-09 17:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D8912652748706@IRSMSX108.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=adewar@brocade.com \
--cc=dev@dpdk.org \
--cc=h.mikita89@gmail.com \
--cc=jblunck@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).