From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6725E20BD for ; Fri, 11 Aug 2017 18:22:26 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2017 09:22:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,358,1498546800"; d="scan'208";a="122606102" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga002.jf.intel.com with ESMTP; 11 Aug 2017 09:22:23 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.220]) by IRSMSX102.ger.corp.intel.com ([169.254.2.91]) with mapi id 14.03.0319.002; Fri, 11 Aug 2017 17:22:23 +0100 From: "Dumitrescu, Cristian" To: Stephen Hemminger , "Singh, Jasvinder" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "hemant.agrawal@nxp.com" , "Jerin.JacobKollanukkaran@cavium.com" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH 0/2] net/softnic: sw fall-back for traffic management Thread-Index: AQHS1kofzek5gL8jNEei9E7E7OP6yqJ/r5+AgAAfZAA= Date: Fri, 11 Aug 2017 16:22:22 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BA982A7@IRSMSX108.ger.corp.intel.com> References: <20170526181149.44085-1-jasvinder.singh@intel.com> <20170811082829.62ab5c0c@xeon-e3> In-Reply-To: <20170811082829.62ab5c0c@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/2] net/softnic: sw fall-back for traffic management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Aug 2017 16:22:27 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, August 11, 2017 4:28 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > Yigit, Ferruh ; hemant.agrawal@nxp.com; > Jerin.JacobKollanukkaran@cavium.com; Lu, Wenzhuo > > Subject: Re: [dpdk-dev] [PATCH 0/2] net/softnic: sw fall-back for traffic > management >=20 > On Fri, 26 May 2017 19:11:47 +0100 > Jasvinder Singh wrote: >=20 > > The SoftNIC PMD provides SW fall-back option for the NICs not supportin= g > > the Traffic Management (TM) features. > > > > SoftNIC PMD overview: > > - The SW fall-back is based on the existing librte_sched DPDK library. > > - The TM-agnostic port (the underlay device) is wrapped into a TM-aware > > softnic port (the overlay device). > > - Once the overlay device (virtual device) is created, the configuratio= n of > > the underlay device is taking place through the overlay device. > > - The SoftNIC PMD is generic, i.e. it works for any underlay device PMD= that > > implements the ethdev API. > > > > Similarly to Ring PMD, the SoftNIC virtual device can be created in t= wo > > different ways: > > 1. Through EAL command line (--vdev option)_ > > 2._Through the rte_eth_softnic_create() API function called by the > application > > > > SoftNIC PMD params: > > - iface (mandatory): the ethdev port name (i.e. PCI address or vdev nam= e) > for > > the underlay device > > - txq_id (optional, default =3D 0): tx queue id of the underlay device > > - deq_bsz (optional, default =3D 24): traffic manager dequeue burst siz= e > > - Example:_ --vdev 'net_softnic0,iface=3D0000:04:00.1,txq_id=3D0,deq_bs= z=3D28' > > > > SoftNIC PMD build instructions: > > - To build SoftNIC PMD, the following parameter needs to be set on > > config/common_base file: CONFIG_RTE_LIBRTE_PMD_SOFTNIC=3Dy > > - The SoftNIC PMD depends on the TM API [1] and therefore is initially > > targeted for the tm-next repository > > > > > > Patch 1 adds softnic device PMD for traffic management. > > Patch 2 adds traffic management ops to the softnic device suggested in > > generic ethdev API for traffic management[1]. > > > > [1] TM API version 4:_ > > http://www.dpdk.org/dev/patchwork/patch/24411/, > > http://www.dpdk.org/dev/patchwork/patch/24412/ > > > > > > Jasvinder Singh (2): > > net/softnic: add softnic PMD for traffic management > > net/softnic: add traffic management ops > > > > MAINTAINERS | 5 + > > config/common_base | 5 + > > drivers/net/Makefile | 5 + > > drivers/net/softnic/Makefile | 58 ++ > > drivers/net/softnic/rte_eth_softnic.c | 578 ++++++++++++ > > drivers/net/softnic/rte_eth_softnic.h | 99 ++ > > drivers/net/softnic/rte_eth_softnic_default.c | 1104 > +++++++++++++++++++++++ > > drivers/net/softnic/rte_eth_softnic_internals.h | 93 ++ > > drivers/net/softnic/rte_eth_softnic_tm.c | 235 +++++ > > drivers/net/softnic/rte_eth_softnic_version.map | 7 + > > mk/rte.app.mk | 5 +- > > 11 files changed, 2193 insertions(+), 1 deletion(-) > > create mode 100644 drivers/net/softnic/Makefile > > create mode 100644 drivers/net/softnic/rte_eth_softnic.c > > create mode 100644 drivers/net/softnic/rte_eth_softnic.h > > create mode 100644 drivers/net/softnic/rte_eth_softnic_default.c > > create mode 100644 drivers/net/softnic/rte_eth_softnic_internals.h > > create mode 100644 drivers/net/softnic/rte_eth_softnic_tm.c > > create mode 100644 drivers/net/softnic/rte_eth_softnic_version.map > > >=20 > Setting up a softnic plus hardware NIC is significantly more effort for > applications > than just using ethdev. Also, it puts the burden on the application to de= cide > which > hardware device needs softnic and which does not; putting hardware > knowledge in the > application is the wrong architectural direction. >=20 > Why not just the simple method of putting an new field in ethdev_ops for > TM. > If it is NULL, then rte_ethdev TM would just fallback to doing the SoftNI= C > processing? >=20 > Also, eth_dev_ops doesn't always have to be const. Aren't there some > PMD's that > insert different values based on configuration or CPU? Hi Stephen, Can you please review V3 and not V1? Code is very much improved, and we have a list of Q&As that address your q= uestions straight away. Thanks, Cristian