From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2BBC7199A9 for ; Thu, 21 Sep 2017 12:25:23 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP; 21 Sep 2017 03:25:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,425,1500966000"; d="scan'208";a="153885816" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga005.fm.intel.com with ESMTP; 21 Sep 2017 03:25:20 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Sep 2017 11:25:20 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by irsmsx112.ger.corp.intel.com ([169.254.1.142]) with mapi id 14.03.0319.002; Thu, 21 Sep 2017 11:25:20 +0100 From: "Dumitrescu, Cristian" To: Pavan Nikhilesh , "stephen@networkplumber.org" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 1/3] eal: move bitmap from lib sched Thread-Index: AQHTMiZyI3A6TOPsAEih7oFbG9w+laK/Igrg Date: Thu, 21 Sep 2017 10:25:18 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BABEA09@IRSMSX108.ger.corp.intel.com> References: <1504795187-11087-1-git-send-email-pbhagavatula@caviumnetworks.com> <1505921833-2286-1-git-send-email-pbhagavatula@caviumnetworks.com> In-Reply-To: <1505921833-2286-1-git-send-email-pbhagavatula@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal: move bitmap from lib sched X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 10:25:23 -0000 Hi Pavan, Thank you, just a couple of minor issues below: > -----Original Message----- > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > Sent: Wednesday, September 20, 2017 4:37 PM > To: Dumitrescu, Cristian ; > stephen@networkplumber.org > Cc: dev@dpdk.org; Pavan Bhagavatula > > Subject: [dpdk-dev] [PATCH v2 1/3] eal: move bitmap from lib sched >=20 > From: Pavan Bhagavatula >=20 > The librte_sched uses rte_bitmap to manage large arrays of bits in an > optimized method so, moving it to eal/common would allow other libraries > and applications to use it. >=20 > Signed-off-by: Pavan Nikhilesh > --- >=20 > v2 changes: > - undo rte_bitmap.h cosmetic changes > - update maintainer info >=20 > lib/librte_eal/common/Makefile | 1 + > lib/{librte_sched =3D> librte_eal/common/include}/rte_bitmap.h | 0 > lib/librte_sched/Makefile | 5 +++-- > lib/librte_sched/rte_sched.c | 2 +- > 4 files changed, 5 insertions(+), 3 deletions(-) > rename lib/{librte_sched =3D> librte_eal/common/include}/rte_bitmap.h > (100%) >=20 > diff --git a/lib/librte_eal/common/Makefile > b/lib/librte_eal/common/Makefile > index e8fd67a..c2c6a7f 100644 > --- a/lib/librte_eal/common/Makefile > +++ b/lib/librte_eal/common/Makefile > @@ -42,6 +42,7 @@ INC +=3D rte_hexdump.h rte_devargs.h rte_bus.h > rte_dev.h rte_vdev.h > INC +=3D rte_pci_dev_feature_defs.h rte_pci_dev_features.h > INC +=3D rte_malloc.h rte_keepalive.h rte_time.h > INC +=3D rte_service.h rte_service_component.h > +INC +=3D rte_bitmap.h >=20 > GENERIC_INC :=3D rte_atomic.h rte_byteorder.h rte_cycles.h rte_prefetch.= h > GENERIC_INC +=3D rte_spinlock.h rte_memcpy.h rte_cpuflags.h rte_rwlock.h > diff --git a/lib/librte_sched/rte_bitmap.h > b/lib/librte_eal/common/include/rte_bitmap.h > similarity index 100% > rename from lib/librte_sched/rte_bitmap.h > rename to lib/librte_eal/common/include/rte_bitmap.h > diff --git a/lib/librte_sched/Makefile b/lib/librte_sched/Makefile > index 18274e7..9a28a9e 100644 > --- a/lib/librte_sched/Makefile > +++ b/lib/librte_sched/Makefile > @@ -55,7 +55,8 @@ SRCS-$(CONFIG_RTE_LIBRTE_SCHED) +=3D rte_sched.c > rte_red.c rte_approx.c > SRCS-$(CONFIG_RTE_LIBRTE_SCHED) +=3D rte_reciprocal.c >=20 > # install includes > -SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include :=3D rte_sched.h > rte_bitmap.h rte_sched_common.h rte_red.h rte_approx.h > -SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include +=3D rte_reciprocal.h > +SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include :=3D rte_sched.h > rte_sched_common.h > +SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include +=3D rte_reciprocal.h > rte_red.h > +SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include +=3D rte_approx.h >=20 These changes are not required, please just remove the rte_bitmap.h from th= is list with no other changes. > include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c > index b7cba11..b3e0d4f 100644 > --- a/lib/librte_sched/rte_sched.c > +++ b/lib/librte_sched/rte_sched.c > @@ -34,6 +34,7 @@ > #include > #include >=20 > +#include Please #include at the end of the #include list. > #include > #include > #include > @@ -44,7 +45,6 @@ > #include >=20 > #include "rte_sched.h" > -#include "rte_bitmap.h" > #include "rte_sched_common.h" > #include "rte_approx.h" > #include "rte_reciprocal.h" > -- > 2.7.4 Regards, Cristian