From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5D9177CB6 for ; Mon, 25 Sep 2017 12:36:41 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2017 03:36:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,435,1500966000"; d="scan'208";a="155111384" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga005.fm.intel.com with ESMTP; 25 Sep 2017 03:36:40 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX152.ger.corp.intel.com ([169.254.6.87]) with mapi id 14.03.0319.002; Mon, 25 Sep 2017 11:36:39 +0100 From: "Dumitrescu, Cristian" To: "alangordondewar@gmail.com" , "Kantecki, Tomasz" CC: "dev@dpdk.org" , Alan Dewar Thread-Topic: [dpdk-dev] [PATCH v3] sched: make RED scaling configurable Thread-Index: AQHTMhIvnjWDIi/kBUu9/omnEgbcKqLFbe0g Date: Mon, 25 Sep 2017 10:36:39 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BAC0754@IRSMSX108.ger.corp.intel.com> References: <1505297744-15240-1-git-send-email-alan.dewar@att.com> <1505913120-5521-1-git-send-email-alan.dewar@att.com> In-Reply-To: <1505913120-5521-1-git-send-email-alan.dewar@att.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] sched: make RED scaling configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 10:36:42 -0000 ... =20 > diff --git a/config/common_base b/config/common_base > index 5e97a08..2626557 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -666,6 +666,13 @@ CONFIG_RTE_SCHED_COLLECT_STATS=3Dn > CONFIG_RTE_SCHED_SUBPORT_TC_OV=3Dn > CONFIG_RTE_SCHED_PORT_N_GRINDERS=3D8 > CONFIG_RTE_SCHED_VECTOR=3Dn > +# > +# RTE_RED_SCALING - number of fractional bits used for RED's moving > average > +# For every bit that RTE_RED_SCALING is reduced, the max-queue size can > doubled > +# RTE_RED_MAX_TH_MAX =3D (max-queue size - 1), max-queue size must be > power of two > +# > +CONFIG_RTE_RED_SCALING=3D10 > +CONFIG_RTE_RED_MAX_TH_MAX=3D1023 >=20 Alan, Tomasz, Thank you for your work! We generally want to avoid build-time configuration in favour of run-time c= onfiguration. Can you please rework this as run-time configuration? I suggest we add a new API function to configure these parameters globally = for all the RED objects (as opposed to per RED object), with the default va= lues as the current values when this function is not called. So NACK for now. Regards, Cristian