From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 124302F7D for ; Mon, 25 Sep 2017 13:05:44 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2017 04:05:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,435,1500966000"; d="scan'208";a="903571747" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by FMSMGA003.fm.intel.com with ESMTP; 25 Sep 2017 04:05:39 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 25 Sep 2017 12:05:38 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX156.ger.corp.intel.com ([169.254.3.33]) with mapi id 14.03.0319.002; Mon, 25 Sep 2017 12:05:39 +0100 From: "Dumitrescu, Cristian" To: Alan Dewar CC: "dev@dpdk.org" Thread-Topic: [PATCH] rte_sched: don't count RED-drops as tail-drops Thread-Index: AQHTHNCspL100rJAxEiVX8zwCo4GKaLFoJgA Date: Mon, 25 Sep 2017 11:05:37 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BAC0788@IRSMSX108.ger.corp.intel.com> References: <1503576011-11389-1-git-send-email-alan.dewar@att.com> In-Reply-To: <1503576011-11389-1-git-send-email-alan.dewar@att.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] rte_sched: don't count RED-drops as tail-drops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 11:05:46 -0000 >=20 > Packets that are RED-dropped are not Tail-dropped, so the n_pkts_dropped > counter should not be incremented when the n_pkts_red_dropped counter > is. >=20 Hi Alan, Not really: * The n_pkts_dropped counter is intended to be incremented every time a pac= ket is dropped, regardless of the drop cause (either tail drop or RED), so = it is cumulative of all drop causes. * The n_pkts_red_dropped counter is only incremented when the drop cause is= RED, so it represents a slice of n_pkts_dropped. Therefore, the number of = packets dropped due to tail drop is (n_pkts_dropped - n_pkts_red_dropped). So NAK. Thanks, Cristian