From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 95BF444BE for ; Thu, 11 Jan 2018 14:11:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 05:11:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,344,1511856000"; d="scan'208";a="18426125" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by FMSMGA003.fm.intel.com with ESMTP; 11 Jan 2018 05:11:06 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX151.ger.corp.intel.com ([169.254.4.108]) with mapi id 14.03.0319.002; Thu, 11 Jan 2018 13:11:05 +0000 From: "Dumitrescu, Cristian" To: "alangordondewar@gmail.com" CC: "dev@dpdk.org" , Alan Dewar , "Kantecki, Tomasz" , "Singh, Jasvinder" Thread-Topic: [PATCH v5] sched: make RED scaling configurable Thread-Index: AQHTiJU2ELlQTwI26UWIYEeOEuz1fKNuoCmw Date: Thu, 11 Jan 2018 13:11:05 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BAFB4EE@IRSMSX108.ger.corp.intel.com> References: <1507022514-21831-1> <1515425232-18888-1-git-send-email-alan.dewar@att.com> In-Reply-To: <1515425232-18888-1-git-send-email-alan.dewar@att.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5] sched: make RED scaling configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 13:11:09 -0000 Hi Alan, More issues and questions below: ... > diff --git a/lib/librte_sched/rte_red.c b/lib/librte_sched/rte_red.h I suggest we use uint32_t for rte_red_scaling and rte_red_max_threshold, ev= en though their values can fit into uint8_t and uint16_t respectively. > diff --git a/lib/librte_sched/rte_red.c b/lib/librte_sched/rte_red.c > +int > +rte_red_set_scaling(uint16_t max_red_queue_length) > +{ > + int8_t count; > + > + if (rte_red_init_done) > + /** > + * Can't change the scaling once the red table has been > + * computed. > + */ > + return -1; Is there a reason why we cannot simply reset the scaling here? > + > + if (max_red_queue_length < RTE_RED_MIN_QUEUE_LENGTH) > + return -2; > + > + if (max_red_queue_length > RTE_RED_MAX_QUEUE_LENGTH) > + return -3; > + > + if (!rte_is_power_of_2(max_red_queue_length)) > + return -4; > + > + count =3D 0; > + while (max_red_queue_length !=3D 0) { > + max_red_queue_length >>=3D 1; > + count++; > + } This does not look right to me. I think you want to compute the log2 of max= _red_queue_length here, but your result (count) is bigger by 1 than it shou= ld be, right? When max_red_queue_length =3D RTE_RED_DEFAULT_QUEUE_LENGTH =3D 1024, the re= sult should be: count =3D RTE_RED_SCALING =3D 10, not 11. I suggest you use rte_bsf32() function for this purpose. > + > + rte_red_scaling -=3D count - RTE_RED_SCALING; Why not simply: rte_red_scaling =3D count? > + rte_red_max_threshold =3D max_red_queue_length - 1; > + return 0; > +} > + > diff --git a/lib/librte_sched/rte_sched_version.map > b/lib/librte_sched/rte_sched_version.map > index 3aa159a..262bece 100644 > --- a/lib/librte_sched/rte_sched_version.map > +++ b/lib/librte_sched/rte_sched_version.map > @@ -29,3 +29,10 @@ DPDK_2.1 { > rte_sched_port_pkt_read_color; >=20 > } DPDK_2.0; > + > +DPDK_17.08 { > + global; > + > + __rte_red_reset; > + rte_red_set_scaling; > +} DPDK_2.1; You need to put the correct DPDK release number here. You also need to do more work to make sure the share library support is no= t broken: -need to increase LIBABIVER in Makefile -need to update the library .so number in release notes -need to check that build does not fail for shared libraries (You can use this patch as example: https://dpdk.org/dev/patchwork/patch/33= 109/ ) > diff --git a/test/test/test_red.c b/test/test/test_red.c The RED test code fails to link, please fix: export RTE_TARGET=3Dx86_64-native-linuxapp-gcc [ ]$ ~/git_dpdk_red/dpdk$ make -C test/test make: Entering directory 'dpdk/test/test' ... LD test test_red.o: In function `test_rte_red_init': test_red.c:(.text+0x2cd): undefined reference to `__rte_red_reset' test_red.c:(.text+0x2da): undefined reference to `rte_red_set_scaling' test_red.c:(.text+0x2ed): undefined reference to `rte_red_max_threshold' test_red.o: In function `increase_actual_qsize': test_red.c:(.text+0x48c): undefined reference to `rte_red_scaling' test_red.c:(.text+0x533): undefined reference to `rte_red_scaling' test_red.o: In function `enqueue_dequeue_func': test_red.c:(.text+0x70c): undefined reference to `rte_red_scaling' test_red.c:(.text+0x7a5): undefined reference to `rte_red_scaling' test_red.o: In function `increase_average_qsize': test_red.c:(.text+0x95c): undefined reference to `rte_red_scaling' test_red.o:test_red.c:(.text+0x9f1): more undefined references to `rte_red_= scaling' follow collect2: error: ld returned 1 exit status dpdk/mk/rte.app.mk:306: recipe for target 'test' failed make: *** [test] Error 1 make: Leaving directory 'dpdk/test/test' Regards, Cristian