DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated.
Date: Tue, 8 May 2018 14:27:54 +0000	[thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BB66780@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20180416102614.64971-1-roy.fan.zhang@intel.com>



> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Monday, April 16, 2018 11:26 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated.
> 
> Coverity issue: 272563
> Fixes: 8245472c58c8 ("examples/ip_pipeline: add sw queue object")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  examples/ip_pipeline/swq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/ip_pipeline/swq.c b/examples/ip_pipeline/swq.c
> index c11bbf27e..be78704c1 100644
> --- a/examples/ip_pipeline/swq.c
> +++ b/examples/ip_pipeline/swq.c
> @@ -64,7 +64,7 @@ swq_create(const char *name, struct swq_params
> *params)
>  	}
> 
>  	/* Node fill in */
> -	strncpy(swq->name, name, sizeof(swq->name));
> +	strncpy(swq->name, name, sizeof(swq->name) - 1);
>  	swq->r = r;
> 
>  	/* Node add to list */
> --
> 2.13.6

Acked-by: Cristian.Dumitrescu <cristian.dumitrescu@intel.com>

Applied to next-pipeline tree, thanks!

  reply	other threads:[~2018-05-08 14:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16 10:26 Fan Zhang
2018-05-08 14:27 ` Dumitrescu, Cristian [this message]
2018-04-16 11:02 Fan Zhang
2018-04-16 13:17 ` Bruce Richardson
2018-05-08 14:28 ` Dumitrescu, Cristian
2018-05-08 19:51   ` Bruce Richardson
2018-05-09  9:26     ` Dumitrescu, Cristian
2018-04-16 16:57 Jasvinder Singh
2018-04-17 13:17 Jasvinder Singh
2018-04-17 14:59 ` Bruce Richardson
2018-04-17 13:28 Jasvinder Singh
2018-04-17 15:01 ` Bruce Richardson
2018-04-17 16:33   ` Singh, Jasvinder
2018-04-18 16:58 [dpdk-dev] [PATCH] examples/ip_pipeline: fixes uninitialized scalar variable Reshma Pattan
2018-04-18 16:58 ` [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated Reshma Pattan
2018-04-19  8:36   ` Singh, Jasvinder
2018-04-18 16:58 ` Reshma Pattan
2018-04-19  8:35   ` Singh, Jasvinder
2018-04-19 11:01 Kevin Laatz
2018-04-19 15:34 ` Singh, Jasvinder
2018-04-19 11:03 Kevin Laatz
2018-04-19 15:33 ` Singh, Jasvinder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EB4FA525960D640B5BDFFD6A3D891267BB66780@IRSMSX108.ger.corp.intel.com \
    --to=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).