* [dpdk-dev] [PATCH] examples/ip_pipeline: fix logically dead node
@ 2018-04-16 10:58 Fan Zhang
2018-04-18 14:03 ` Singh, Jasvinder
2018-05-08 14:28 ` Dumitrescu, Cristian
0 siblings, 2 replies; 3+ messages in thread
From: Fan Zhang @ 2018-04-16 10:58 UTC (permalink / raw)
To: dev; +Cc: cristian.dumitrescu, jasvinder.singh
Coverity issue: 272567
Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object")
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
examples/ip_pipeline/cli.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index 199a31ff8..6c07ca223 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -1890,12 +1890,6 @@ cmd_pipeline_table(char **tokens,
t0 += 6;
} else if (strcmp(tokens[t0], "stub") == 0) {
- if (n_tokens < t0 + 1) {
- snprintf(out, out_size, MSG_ARG_MISMATCH,
- "pipeline table stub");
- return;
- }
-
p.match_type = TABLE_STUB;
t0 += 1;
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix logically dead node
2018-04-16 10:58 [dpdk-dev] [PATCH] examples/ip_pipeline: fix logically dead node Fan Zhang
@ 2018-04-18 14:03 ` Singh, Jasvinder
2018-05-08 14:28 ` Dumitrescu, Cristian
1 sibling, 0 replies; 3+ messages in thread
From: Singh, Jasvinder @ 2018-04-18 14:03 UTC (permalink / raw)
To: Zhang, Roy Fan, dev; +Cc: Dumitrescu, Cristian
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Monday, April 16, 2018 11:58 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix logically dead node
>
> Coverity issue: 272567
> Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object")
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> examples/ip_pipeline/cli.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index
> 199a31ff8..6c07ca223 100644
> --- a/examples/ip_pipeline/cli.c
> +++ b/examples/ip_pipeline/cli.c
> @@ -1890,12 +1890,6 @@ cmd_pipeline_table(char **tokens,
>
> t0 += 6;
> } else if (strcmp(tokens[t0], "stub") == 0) {
> - if (n_tokens < t0 + 1) {
> - snprintf(out, out_size, MSG_ARG_MISMATCH,
> - "pipeline table stub");
> - return;
> - }
> -
> p.match_type = TABLE_STUB;
>
> t0 += 1;
> --
> 2.13.6
Reviewed-by: Jasvinder Singh <jasvindeer.singh@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix logically dead node
2018-04-16 10:58 [dpdk-dev] [PATCH] examples/ip_pipeline: fix logically dead node Fan Zhang
2018-04-18 14:03 ` Singh, Jasvinder
@ 2018-05-08 14:28 ` Dumitrescu, Cristian
1 sibling, 0 replies; 3+ messages in thread
From: Dumitrescu, Cristian @ 2018-05-08 14:28 UTC (permalink / raw)
To: Zhang, Roy Fan, dev; +Cc: Singh, Jasvinder
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Monday, April 16, 2018 11:58 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix logically dead node
>
> Coverity issue: 272567
> Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object")
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> examples/ip_pipeline/cli.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
> index 199a31ff8..6c07ca223 100644
> --- a/examples/ip_pipeline/cli.c
> +++ b/examples/ip_pipeline/cli.c
> @@ -1890,12 +1890,6 @@ cmd_pipeline_table(char **tokens,
>
> t0 += 6;
> } else if (strcmp(tokens[t0], "stub") == 0) {
> - if (n_tokens < t0 + 1) {
> - snprintf(out, out_size, MSG_ARG_MISMATCH,
> - "pipeline table stub");
> - return;
> - }
> -
> p.match_type = TABLE_STUB;
>
> t0 += 1;
> --
> 2.13.6
Acked-by: Cristian.Dumitrescu <cristian.dumitrescu@intel.com>
Applied to next-pipeline tree, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-08 14:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-16 10:58 [dpdk-dev] [PATCH] examples/ip_pipeline: fix logically dead node Fan Zhang
2018-04-18 14:03 ` Singh, Jasvinder
2018-05-08 14:28 ` Dumitrescu, Cristian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).