From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A2614AAD1 for ; Wed, 9 May 2018 11:26:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2018 02:26:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,381,1520924400"; d="scan'208";a="39852870" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga008.jf.intel.com with ESMTP; 09 May 2018 02:26:19 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX102.ger.corp.intel.com ([169.254.2.83]) with mapi id 14.03.0319.002; Wed, 9 May 2018 10:26:18 +0100 From: "Dumitrescu, Cristian" To: "Richardson, Bruce" CC: "Zhang, Roy Fan" , "dev@dpdk.org" , "Singh, Jasvinder" Thread-Topic: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated Thread-Index: AQHT1XN7hqMZPeayIEqG9a7kgU8u8qQmBrjggABJeQCAAPQHIA== Date: Wed, 9 May 2018 09:26:18 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BB68F52@IRSMSX108.ger.corp.intel.com> References: <20180416110233.66450-1-roy.fan.zhang@intel.com> <3EB4FA525960D640B5BDFFD6A3D891267BB667A3@IRSMSX108.ger.corp.intel.com> <20180508195118.GA18108@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20180508195118.GA18108@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 09:26:22 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, May 8, 2018 8:51 PM > To: Dumitrescu, Cristian > Cc: Zhang, Roy Fan ; dev@dpdk.org; Singh, > Jasvinder > Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null > terminated >=20 > On Tue, May 08, 2018 at 02:28:25PM +0000, Dumitrescu, Cristian wrote: > > > > > > > -----Original Message----- > > > From: Zhang, Roy Fan > > > Sent: Monday, April 16, 2018 12:03 PM > > > To: dev@dpdk.org > > > Cc: Dumitrescu, Cristian ; Singh, > Jasvinder > > > > > > Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated > > > > > > Coverity issue: 272572 > > > Fixes: 719374345cee ("examples/ip_pipeline: add action profile object= s") > > > > > > Signed-off-by: Fan Zhang > > > --- > > > examples/ip_pipeline/action.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/examples/ip_pipeline/action.c > b/examples/ip_pipeline/action.c > > > index 77a04fe19..91011ebe8 100644 > > > --- a/examples/ip_pipeline/action.c > > > +++ b/examples/ip_pipeline/action.c > > > @@ -133,7 +133,7 @@ port_in_action_profile_create(const char > *name, > > > } > > > > > > /* Node fill in */ > > > - strncpy(profile->name, name, sizeof(profile->name)); > > > + strncpy(profile->name, name, sizeof(profile->name) - 1); > > > memcpy(&profile->params, params, sizeof(*params)); > > > profile->ap =3D ap; > > > > > > -- > > > 2.13.6 > > > > Acked-by: Cristian.Dumitrescu > > > > Applied to next-pipeline tree, thanks! >=20 > This is not a correct fix, and the code is still broken. However, I see > that you have actually applied the correct v2 patch to the tree, so no bi= g > deal. It's probably best to reply to the correct patch confirming it's > applied, though. >=20 > /Bruce Yes, the right patch (v2) was applied, the wrong email was replied.