From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 7BDB71BDF1 for ; Fri, 15 Jun 2018 17:31:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jun 2018 08:31:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,227,1526367600"; d="scan'208";a="64427728" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga001.fm.intel.com with ESMTP; 15 Jun 2018 08:31:31 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX151.ger.corp.intel.com ([169.254.4.216]) with mapi id 14.03.0319.002; Fri, 15 Jun 2018 16:31:29 +0100 From: "Dumitrescu, Cristian" To: "Laatz, Kevin" , "dev@dpdk.org" CC: "Singh, Jasvinder" Thread-Topic: [PATCH] examples/ip_pipeline: add link show to the cli Thread-Index: AQHT/0YppBug4mZuIkqcEWNgOpUgOKRWkDPggArSuwCAABlRsA== Date: Fri, 15 Jun 2018 15:31:28 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E75A47F@IRSMSX108.ger.corp.intel.com> References: <20180608163053.37891-1-kevin.laatz@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E757604@IRSMSX108.ger.corp.intel.com> <17B8B96B619B7A459C5ACA628B274952BFF8E8@IRSMSX103.ger.corp.intel.com> In-Reply-To: <17B8B96B619B7A459C5ACA628B274952BFF8E8@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: add link show to the cli X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 15:31:32 -0000 Hi Kevin, If you only need access to this linked list for iterating through it, you c= an add a new function: struct link *link_next(struct link *) that gets you = the next element in the list (for first element, invoke with link =3D NULL;= at and of list, it returns NULL). Makes sense? Are there other usages of this linked list that you need to cover? Regards, Cristian > -----Original Message----- > From: Laatz, Kevin > Sent: Friday, June 15, 2018 3:57 PM > To: Dumitrescu, Cristian ; dev@dpdk.org > Cc: Singh, Jasvinder > Subject: RE: [PATCH] examples/ip_pipeline: add link show to the cli >=20 > Hi Cristian, >=20 > > > + > > > + link_list =3D links_get(); > > > > We don't need this function, the lined list of links is a global public= object, > > please access it directly. >=20 > link_list is declared as a static struct in link.c so it is not accessibl= e from cli.c >=20 > I can either leave this function in to pass the pointer to the cli.c or m= ove the > declaration to link.h. > Do you have a preference? >=20 > > > > > > +struct link_list * > > > +links_get(void) > > > +{ > > > + return &link_list; > > > +} > > > + > > > > Function to be removed, used linked list of links directly (see comment > > above). >=20 > See above comment >=20 > Thanks, > Kevin