From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agent
Date: Thu, 12 Jul 2018 12:02:17 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E772F65@IRSMSX107.ger.corp.intel.com> (raw)
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, July 11, 2018 8:58 PM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>
> Cc: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agent
>
> 05/07/2018 17:47, Jasvinder Singh:
> > Add connection agent to enable connectivity with external agen (e.g.
> > telnet, netcat, Python script, etc).
> >
> > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > ---
> > config/common_base | 2 +-
> > config/common_linuxapp | 1 +
> > drivers/net/softnic/Makefile | 12 +-
> > drivers/net/softnic/conn.c | 332 +++++++++++++++++++++
> > drivers/net/softnic/conn.h | 49 +++
> > drivers/net/softnic/rte_eth_softnic.c | 79 ++++-
> > drivers/net/softnic/rte_eth_softnic.h | 16 +
> > drivers/net/softnic/rte_eth_softnic_internals.h | 3 +
> > ...nic_version.map => rte_eth_softnic_version.map} | 6 +
> > 9 files changed, 496 insertions(+), 4 deletions(-) create mode
> > 100644 drivers/net/softnic/conn.c create mode 100644
> > drivers/net/softnic/conn.h rename
> > drivers/net/softnic/{rte_pmd_softnic_version.map =>
> > rte_eth_softnic_version.map} (52%)
>
> Why are you renaming this file?
>
> If you test the compilation with devtools/test-meson-builds.sh you will see this
> error:
> drivers/meson.build:111:3: ERROR:
> File drivers/net/softnic/rte_pmd_softnic_version.map does not exist.
>
>
Fixed. Rebased on DPDK master latest as well.
> > +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp")
> > +$(info Softnic PMD can only operate in a linuxapp environment, \
>
> I think it is a really wrong idea to limit softnic to Linux only.
>
Main reasons are: use of epoll API, use of TAP ports, etc which are Linux only. At some point we'll consider re-implementing some of the internals with alternatives that are portable to Free BSD as well.
next reply other threads:[~2018-07-12 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 12:02 Dumitrescu, Cristian [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-27 16:31 [dpdk-dev] [PATCH v3 01/23] net/softnic: restructuring Jasvinder Singh
2018-07-05 15:47 ` [dpdk-dev] [PATCH v4 00/23] net/softnic: refactoring Jasvinder Singh
2018-07-05 15:47 ` [dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agent Jasvinder Singh
2018-07-11 19:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D891268E772F65@IRSMSX107.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).