From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 8ACD9235; Tue, 24 Jul 2018 19:39:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2018 10:39:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,398,1526367600"; d="scan'208";a="247990487" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga005.fm.intel.com with ESMTP; 24 Jul 2018 10:39:20 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX103.ger.corp.intel.com ([169.254.3.208]) with mapi id 14.03.0319.002; Tue, 24 Jul 2018 18:39:19 +0100 From: "Dumitrescu, Cristian" To: Moti Haimovsky , "thomas@monjalon.net" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Singh, Jasvinder" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: workaround softnic CLI modifications Thread-Index: AQHUI2qEHw7VislCy02rMvpDgTZDjqSeojaw Date: Tue, 24 Jul 2018 17:39:19 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E779325@IRSMSX107.ger.corp.intel.com> References: <1532449282-9352-1-git-send-email-motih@mellanox.com> In-Reply-To: <1532449282-9352-1-git-send-email-motih@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: workaround softnic CLI modifications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 17:39:24 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Moti Haimovsky > Sent: Tuesday, July 24, 2018 5:21 PM > To: thomas@monjalon.net > Cc: dev@dpdk.org; stable@dpdk.org; Moti Haimovsky > > Subject: [dpdk-dev] [PATCH] app/testpmd: workaround softnic CLI > modifications >=20 > This patch returns the previous testpmd command line handling > routines (namely cmdline_interact and cmdline_stdin_exit) to the > prompt routine in order to overcome testpmd abnormal exit observed on > several setups. > These routines will only by used when testpmd is compiled without > support for RTE_LIBRTE_PMD_SOFTNIC >=20 > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > Cc: stable@dpdk.org >=20 > Signed-off-by: Moti Haimovsky > --- > app/test-pmd/cmdline.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) >=20 We should probably fix the issue in the cmdline library to bring cmdline_po= ll() on parity with cmdline_interact(), but this is a decent workaround to = avoid breaking those automation scripts that rely on Ctrl+D behavior. Acked-by: Cristian Dumitrescu