From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C32D198 for ; Wed, 25 Jul 2018 10:49:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2018 01:49:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,400,1526367600"; d="scan'208";a="70137541" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 25 Jul 2018 01:49:45 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 25 Jul 2018 09:49:45 +0100 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by irsmsx112.ger.corp.intel.com ([169.254.1.22]) with mapi id 14.03.0319.002; Wed, 25 Jul 2018 09:49:44 +0100 From: "Dumitrescu, Cristian" To: "Singh, Jasvinder" , Thomas Monjalon CC: "dev@dpdk.org" , Mordechay Haimovsky , "Iremonger, Bernard" , "Pattan, Reshma" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d Thread-Index: AQHUInJOmSIrvnKxS0eFgvH0FQENVqSeLF2AgAATHYCAACKJAIAAMx8QgAD1bYCAAANoAIAAE/3Q Date: Wed, 25 Jul 2018 08:49:43 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E7796AF@IRSMSX107.ger.corp.intel.com> References: <20180723104425.10090-1-jasvinder.singh@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E7792AF@IRSMSX107.ger.corp.intel.com> <1707406.j7eEjrHijo@xps> <54CBAA185211B4429112C315DA58FF6D335DD24E@IRSMSX103.ger.corp.intel.com> In-Reply-To: <54CBAA185211B4429112C315DA58FF6D335DD24E@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 08:49:48 -0000 > -----Original Message----- > From: Singh, Jasvinder > Sent: Wednesday, July 25, 2018 9:31 AM > To: Thomas Monjalon ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Mordechay Haimovsky ; > Iremonger, Bernard ; Pattan, Reshma > ; olivier.matz@6wind.com > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+= d >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Wednesday, July 25, 2018 9:19 AM > > To: Dumitrescu, Cristian > > Cc: dev@dpdk.org; Mordechay Haimovsky ; Singh, > > Jasvinder ; Iremonger, Bernard > > ; Pattan, Reshma > > ; olivier.matz@6wind.com > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctr= l+d > > > > 24/07/2018 18:59, Dumitrescu, Cristian: > > > From: Mordechay Haimovsky [mailto:motih@mellanox.com] > > > > > > > > Even after this fix we still have setups that use netvsc for > > > > example, on which testpmd exits with rte_panic right after loading > > > > it even without touching the KBD. > > > > > > > > I recommend returning the previous prompt routine in > > > > test-pmd/cmdline.c and rework the SOFTNIC section there, preferably > > > > moving its poll section to use rte_service in a separate file > > > > cleaning the CLI files from PMD-specific implementation. > > > > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > > > > > > Important note: > > > > > testpmd is currently really broken. > > > > > We cannot have a RC2 until it is fixed. > > > > > > > > > > > First, testpmd is not really broken, as only thing that changed is th= e Ctrl + > D > > behavior. I agree this is an issue that we need to fix, as it looks tha= t it is > > breaking some automation scripts for some people. > > > > > > The change in behavior for Ctrl + D exit is caused by replacing the c= all to > > cmdline_interact() with calling cmdline_poll() in a loop. These two > approaches > > should be identical in behavior, but it looks like they are not due to = some > issue > > in the cmdline library. Jasvinder proposed a quick patch, but it looks = like > > something else needs to be fixed in cmdline library in order to bring > > cmdline_poll() on parity with cmdline_interact(). Any advice from Olivi= er > would > > be very much appreciated! > > > > > > It is really a bad practice to use cmdline_interact() in testpmd, as = it is a > > blocking call that prohibits doing other things on the same thread that= runs > the > > CLI. Sometimes we need to run other things on the same core, e.g. the > slow > > softnic_manage() function. > > > > > > Worst case scenario: We can revert the cmdline_poll() back to > > cmdline_interact(), this is a small change, but not the proper way of d= oing > > things, as this is simply hiding the issue in cmdline library. It would= also > prevent > > us from testing some Soft NIC functionality. > > > > There are some crashes, even without touching the keyboard. >=20 > Thomas, could you be specific here so that we can reproduce the issues yo= u > are mentioning? Thanks. >=20 Yeah, I think the crash mention was about a custom automation script relyin= g on Ctrl+D behavior, not about tespmd crash. Moti, please clarify. > > So yes, we should revert. > >