From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 407BF98 for ; Wed, 25 Jul 2018 13:57:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2018 04:57:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,401,1526367600"; d="scan'208";a="67406991" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by FMSMGA003.fm.intel.com with ESMTP; 25 Jul 2018 04:56:58 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX104.ger.corp.intel.com ([169.254.5.225]) with mapi id 14.03.0319.002; Wed, 25 Jul 2018 12:56:57 +0100 From: "Dumitrescu, Cristian" To: "Ananyev, Konstantin" , Mordechay Haimovsky , Thomas Monjalon , "Singh, Jasvinder" CC: "dev@dpdk.org" , "Iremonger, Bernard" , "Pattan, Reshma" , "olivier.matz@6wind.com" , "Van Haaren, Harry" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d Thread-Index: AQHUInJOmSIrvnKxS0eFgvH0FQENVqSeLF2AgAATHYCAACKJAIAAMx8QgAECMQCAABhfgIAAEs4AgAAVdVA= Date: Wed, 25 Jul 2018 11:56:56 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E7797DD@IRSMSX107.ger.corp.intel.com> References: <20180723104425.10090-1-jasvinder.singh@intel.com> <1876510.4y0gDTZx5Q@xps> <1925999.Zqez9Xlb98@xps> <3EB4FA525960D640B5BDFFD6A3D891268E7792AF@IRSMSX107.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258DF51D3C1@irsmsx105.ger.corp.intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E779722@IRSMSX107.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258DF51D5A2@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258DF51D5A2@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 11:57:23 -0000 > -----Original Message----- > From: Ananyev, Konstantin > Sent: Wednesday, July 25, 2018 12:39 PM > To: Dumitrescu, Cristian ; Mordechay > Haimovsky ; Thomas Monjalon > ; Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; > Pattan, Reshma ; olivier.matz@6wind.com; Van > Haaren, Harry > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+= d >=20 >=20 >=20 > > -----Original Message----- > > From: Dumitrescu, Cristian > > Sent: Wednesday, July 25, 2018 10:36 AM > > To: Ananyev, Konstantin ; Mordechay > Haimovsky ; Thomas Monjalon > > ; Singh, Jasvinder > > Cc: dev@dpdk.org; Iremonger, Bernard ; > Pattan, Reshma ; > > olivier.matz@6wind.com > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctr= l+d > > > > > > > > > -----Original Message----- > > > From: Ananyev, Konstantin > > > Sent: Wednesday, July 25, 2018 10:04 AM > > > To: Dumitrescu, Cristian ; Mordechay > > > Haimovsky ; Thomas Monjalon > > > ; Singh, Jasvinder > > > Cc: dev@dpdk.org; Iremonger, Bernard ; > > > Pattan, Reshma ; olivier.matz@6wind.com > > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using > ctrl+d > > > > > > > > > > > > > -----Original Message----- > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dumitrescu, > > > Cristian > > > > Sent: Tuesday, July 24, 2018 5:59 PM > > > > To: Mordechay Haimovsky ; Thomas Monjalon > > > ; Singh, Jasvinder > > > > > > > > Cc: dev@dpdk.org; Iremonger, Bernard > ; > > > Pattan, Reshma ; > > > > olivier.matz@6wind.com > > > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using > ctrl+d > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Mordechay Haimovsky [mailto:motih@mellanox.com] > > > > > Sent: Tuesday, July 24, 2018 3:37 PM > > > > > To: Thomas Monjalon ; Singh, Jasvinder > > > > > > > > > > Cc: dev@dpdk.org; Iremonger, Bernard > ; > > > > > Pattan, Reshma ; > olivier.matz@6wind.com; > > > > > Dumitrescu, Cristian > > > > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit usi= ng > > > ctrl+d > > > > > > > > > > Even after this fix we still have setups that use netvsc for exa= mple, > on > > > > > which testpmd exits with rte_panic right after loading it even > without > > > > > touching the KBD. > > > > > > > > > > I recommend returning the previous prompt routine in test- > > > pmd/cmdline.c > > > > > and rework the SOFTNIC section there, preferably moving its poll > section > > > to > > > > > use rte_service in a separate file cleaning the CLI files from PM= D- > specific > > > > > implementation. > > > > > > > > > > > -----Original Message----- > > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > > Sent: Tuesday, July 24, 2018 3:34 PM > > > > > > To: Jasvinder Singh > > > > > > Cc: dev@dpdk.org; bernard.iremonger@intel.com; > > > > > > reshma.pattan@intel.com; Mordechay Haimovsky > > > > > ; > > > > > > olivier.matz@6wind.com; cristian.dumitrescu@intel.com > > > > > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit > using > > > ctrl+d > > > > > > > > > > > > Important note: > > > > > > testpmd is currently really broken. > > > > > > We cannot have a RC2 until it is fixed. > > > > > > > > > > > > > > > > > > 24/07/2018 13:25, Thomas Monjalon: > > > > > > > 23/07/2018 12:44, Jasvinder Singh: > > > > > > > > Fix testpmd app exit by pressing ctrl+d, End-of-Transmissio= n > > > > > > > > character (EOT) on the empty command line. > > > > > > > > > > > > > > Please describe what is the issue and what is the cause. > > > > > > > > > > > > > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward > > > mode") > > > > > > > > > > > > > > > > Reported-by: Mordechay Haimovsky > > > > > > > > Signed-off-by: Jasvinder Singh > > > > > > > > --- > > > > > > > > app/test-pmd/cmdline.c | 10 ++++++---- > > > > > > > > lib/librte_cmdline/cmdline.c | 2 +- > > > > > > > > > > > > > > It is very suspicious to change the cmdline library. > > > > > > > If there is a bug in this library, it deserves a separate fix= . > > > > > > > > > > > > > > > > > > > > > > > > First, testpmd is not really broken, as only thing that changed is = the Ctrl > + > > > D behavior. I agree this is an issue that we need to fix, as > > > > it looks that it is breaking some automation scripts for some peopl= e. > > > > > > > > The change in behavior for Ctrl + D exit is caused by replacing the= call > to > > > cmdline_interact() with calling cmdline_poll() in a loop. > > > > These two approaches should be identical in behavior, but it looks = like > they > > > are not due to some issue in the cmdline library. > > > > Jasvinder proposed a quick patch, but it looks like something else = needs > to > > > be fixed in cmdline library in order to bring > > > > cmdline_poll() on parity with cmdline_interact(). Any advice from > Olivier > > > would be very much appreciated! > > > > > > > > It is really a bad practice to use cmdline_interact() in testpmd, a= s it is a > > > blocking call that prohibits doing other things on the same > > > > thread that runs the CLI. Sometimes we need to run other things on = the > > > same core, e.g. the slow softnic_manage() function. > > > > > > Curious why not use a service core for softnic background stuff, and = leave > CLI > > > one for CLI? > > > Konstantin > > > > I guess for a test application you can do anything you want, but in rea= l life > CPU cores are really expensive and dedicating a CPU core > > just for CLI is a colossal waste. >=20 > Ok, but let's application developer to decide how to use (waste) the core= s he > owns :) > What I am saying: there is a special thing (developed by Harry) service c= ores. > As I understand why of it's the purpose - allow PMD(s) to allocate CPU > resources for > there background tasks in a unified and transparent way. > From the description above - that seems to fit your needs (softnic > background processing), no? > Konstantin >=20 Then why not put the testpmd CLI itself on a service core? Are you voluntee= ring for a patch on this? :) > > > > We did use the non-blocking cmdline_poll() function instead of the > blocking cmdline_interact() in the past without any issues. The > > issues reported by Moti come as a surprise. It is probably good to see = what > this is about and see if we can quickly fix the issue in > > cmdline library. Otherwise, we can revert the usage of cmdline_poll() w= ith > cmdline_interact(). > > > > > > > > > > > > > > > Worst case scenario: We can revert the cmdline_poll() back to > > > cmdline_interact(), this is a small change, but not the proper way of > > > > doing things, as this is simply hiding the issue in cmdline library= . It > would > > > also prevent us from testing some Soft NIC functionality.