From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 96CA71B277 for ; Fri, 28 Sep 2018 13:32:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Sep 2018 04:32:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,314,1534834800"; d="scan'208";a="267731678" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga006.fm.intel.com with ESMTP; 28 Sep 2018 04:32:18 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX102.ger.corp.intel.com ([169.254.2.67]) with mapi id 14.03.0319.002; Fri, 28 Sep 2018 12:32:17 +0100 From: "Dumitrescu, Cristian" To: "Zhang, Roy Fan" , "dev@dpdk.org" Thread-Topic: [PATCH v3] port: add sym crypto port Thread-Index: AQHUVxn65CLMblOo8kGaEqDYIN872qUFj05Q Date: Fri, 28 Sep 2018 11:32:17 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E7CD580@IRSMSX107.ger.corp.intel.com> References: <20180820142927.28432-1-roy.fan.zhang@intel.com> <20180928104139.15760-1-roy.fan.zhang@intel.com> In-Reply-To: <20180928104139.15760-1-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODcxNjUyNGYtM2JkMS00ZTZiLWI1ZGMtYjBiYWNiN2NjMzg3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNTJXYlhxMjEreDdkVnFKRjZWRm5LS21lXC9MWHdUOFRKaVQzQ093M01iUWdPbFVnT01jTTdOTkF1M2QwNXhIQlAifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] port: add sym crypto port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Sep 2018 11:32:21 -0000 > -----Original Message----- > From: Zhang, Roy Fan > Sent: Friday, September 28, 2018 11:42 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Zhang, Roy Fan > ; Zhang > Subject: [PATCH v3] port: add sym crypto port >=20 > From: "Zhang, Roy Fan" >=20 > This patch adds the symmetric crypto support to port library. > The crypto port acts as a shim layer to DPDK cryptodev library and > supports in-place crypto workload processing. >=20 > Signed-off-by: Zhang, Roy Fan > Acked-by: Dumitrescu, Cristian > --- > v3: > - fixed a compile issue >=20 > v2: > - added experimental flags > - enabled meson build >=20 > lib/librte_port/Makefile | 4 +- > lib/librte_port/meson.build | 8 +- > lib/librte_port/rte_port_sym_crypto.c | 553 > ++++++++++++++++++++++++++++++++++ > lib/librte_port/rte_port_sym_crypto.h | 97 ++++++ > lib/librte_port/rte_port_version.map | 8 + > 5 files changed, 666 insertions(+), 4 deletions(-) > create mode 100644 lib/librte_port/rte_port_sym_crypto.c > create mode 100644 lib/librte_port/rte_port_sym_crypto.h >=20 > diff --git a/lib/librte_port/Makefile b/lib/librte_port/Makefile > index 8df4864ed..1b83f6f2b 100644 > --- a/lib/librte_port/Makefile > +++ b/lib/librte_port/Makefile > @@ -11,7 +11,7 @@ ifeq ($(CONFIG_RTE_PORT_PCAP),y) > LDLIBS +=3D -lpcap > endif > LDLIBS +=3D -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev > -LDLIBS +=3D -lrte_ip_frag -lrte_sched > +LDLIBS +=3D -lrte_ip_frag -lrte_sched -lrte_cryptodev > ifeq ($(CONFIG_RTE_LIBRTE_KNI),y) > LDLIBS +=3D -lrte_kni > endif > @@ -38,6 +38,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_KNI),y) > SRCS-$(CONFIG_RTE_LIBRTE_PORT) +=3D rte_port_kni.c > endif > SRCS-$(CONFIG_RTE_LIBRTE_PORT) +=3D rte_port_source_sink.c > +SRCS-$(CONFIG_RTE_LIBRTE_PORT) +=3D rte_port_sym_crypto.c >=20 > # install includes > SYMLINK-$(CONFIG_RTE_LIBRTE_PORT)-include +=3D rte_port.h > @@ -53,5 +54,6 @@ ifeq ($(CONFIG_RTE_LIBRTE_KNI),y) > SYMLINK-$(CONFIG_RTE_LIBRTE_PORT)-include +=3D rte_port_kni.h > endif > SYMLINK-$(CONFIG_RTE_LIBRTE_PORT)-include +=3D rte_port_source_sink.h > +SYMLINK-$(CONFIG_RTE_LIBRTE_PORT)-include +=3D rte_port_sym_crypto.h >=20 > include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/lib/librte_port/meson.build b/lib/librte_port/meson.build > index f3d8b4434..0d11456f0 100644 > --- a/lib/librte_port/meson.build > +++ b/lib/librte_port/meson.build > @@ -9,7 +9,8 @@ sources =3D files( > 'rte_port_ras.c', > 'rte_port_ring.c', > 'rte_port_sched.c', > - 'rte_port_source_sink.c') > + 'rte_port_source_sink.c', > + 'rte_port_sym_crypto.c') > headers =3D files( > 'rte_port_ethdev.h', > 'rte_port_fd.h', > @@ -18,8 +19,9 @@ headers =3D files( > 'rte_port.h', > 'rte_port_ring.h', > 'rte_port_sched.h', > - 'rte_port_source_sink.h') > -deps +=3D ['ethdev', 'sched', 'ip_frag'] > + 'rte_port_source_sink.h', > + 'rte_port_sym_crypto.h') > +deps +=3D ['ethdev', 'sched', 'ip_frag', 'cryptodev'] >=20 > if dpdk_conf.has('RTE_LIBRTE_KNI') > sources +=3D files('rte_port_kni.c') > diff --git a/lib/librte_port/rte_port_sym_crypto.c > b/lib/librte_port/rte_port_sym_crypto.c > new file mode 100644 > index 000000000..aa3de4fdf > --- /dev/null > +++ b/lib/librte_port/rte_port_sym_crypto.c > @@ -0,0 +1,553 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 Intel Corporation > + */ > +#include > + > +#include > +#include > + > +#include "rte_port_sym_crypto.h" > + > +/* > + * Port Crypto Reader > + */ > +#ifdef RTE_PORT_STATS_COLLECT > + > +#define RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_IN_ADD(port, val) > \ > + port->stats.n_pkts_in +=3D val > +#define RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_DROP_ADD(port, > val) \ > + port->stats.n_pkts_drop +=3D val > + > +#else > + > +#define RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_IN_ADD(port, val) > +#define RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_DROP_ADD(port, > val) > + > +#endif > + > +struct rte_port_sym_crypto_reader { > + struct rte_port_in_stats stats; > + > + uint8_t cryptodev_id; > + uint16_t queue_id; > + struct rte_crypto_op *ops[RTE_PORT_IN_BURST_SIZE_MAX]; > + rte_port_sym_crypto_reader_callback_fn f_callback; > + void *arg_callback; > +}; > + > +static void * > +rte_port_sym_crypto_reader_create(void *params, int socket_id) > +{ > + struct rte_port_sym_crypto_reader_params *conf =3D > + params; > + struct rte_port_sym_crypto_reader *port; > + > + /* Check input parameters */ > + if (conf =3D=3D NULL) { > + RTE_LOG(ERR, PORT, "%s: params is NULL\n", __func__); > + return NULL; > + } > + > + /* Memory allocation */ > + port =3D rte_zmalloc_socket("PORT", sizeof(*port), > + RTE_CACHE_LINE_SIZE, socket_id); > + if (port =3D=3D NULL) { > + RTE_LOG(ERR, PORT, "%s: Failed to allocate port\n", > __func__); > + return NULL; > + } > + > + /* Initialization */ > + port->cryptodev_id =3D conf->cryptodev_id; > + port->queue_id =3D conf->queue_id; > + port->f_callback =3D conf->f_callback; > + port->arg_callback =3D conf->arg_callback; > + > + return port; > +} > + > +static int > +rte_port_sym_crypto_reader_rx(void *port, struct rte_mbuf **pkts, > uint32_t n_pkts) > +{ > + struct rte_port_sym_crypto_reader *p =3D > + port; > + uint16_t rx_ops_cnt, i, n =3D 0; > + > + rx_ops_cnt =3D rte_cryptodev_dequeue_burst(p->cryptodev_id, p- > >queue_id, > + p->ops, n_pkts); > + > + for (i =3D 0; i < rx_ops_cnt; i++) { > + struct rte_crypto_op *op =3D p->ops[i]; > + > + /** Drop failed pkts */ > + if (unlikely(op->status !=3D > RTE_CRYPTO_OP_STATUS_SUCCESS)) { > + rte_pktmbuf_free(op->sym->m_src); > + continue; > + } > + > + pkts[n++] =3D op->sym->m_src; > + } > + > + if (p->f_callback) > + (*p->f_callback)(pkts, n, p->arg_callback); > + > + RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_IN_ADD(p, n); > + RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_DROP_ADD(p, > rx_pkt_cnt - n); > + > + return n; > +} > + > +static int > +rte_port_sym_crypto_reader_free(void *port) > +{ > + if (port =3D=3D NULL) { > + RTE_LOG(ERR, PORT, "%s: port is NULL\n", __func__); > + return -EINVAL; > + } > + > + rte_free(port); > + > + return 0; > +} > + > +static int rte_port_sym_crypto_reader_stats_read(void *port, > + struct rte_port_in_stats *stats, int clear) > +{ > + struct rte_port_sym_crypto_reader *p =3D > + port; > + > + if (stats !=3D NULL) > + memcpy(stats, &p->stats, sizeof(p->stats)); > + > + if (clear) > + memset(&p->stats, 0, sizeof(p->stats)); > + > + return 0; > +} > + > +/* > + * Port crypto Writer > + */ > +#ifdef RTE_PORT_STATS_COLLECT > + > +#define RTE_PORT_SYM_CRYPTO_WRITER_STATS_PKTS_IN_ADD(port, val) > \ > + port->stats.n_pkts_in +=3D val > +#define RTE_PORT_SYM_CRYPTO_WRITER_STATS_PKTS_DROP_ADD(port, > val) \ > + port->stats.n_pkts_drop +=3D val > + > +#else > + > +#define RTE_PORT_SYM_CRYPTO_WRITER_STATS_PKTS_IN_ADD(port, val) > +#define RTE_PORT_SYM_CRYPTO_WRITER_STATS_PKTS_DROP_ADD(port, > val) > + > +#endif > + > +struct rte_port_sym_crypto_writer { > + struct rte_port_out_stats stats; > + > + struct rte_crypto_op *tx_buf[2 * RTE_PORT_IN_BURST_SIZE_MAX]; > + > + uint32_t tx_burst_sz; > + uint32_t tx_buf_count; > + uint64_t bsz_mask; > + > + uint8_t cryptodev_id; > + uint16_t queue_id; > + uint16_t crypto_op_offset; > +}; > + > +static void * > +rte_port_sym_crypto_writer_create(void *params, int socket_id) > +{ > + struct rte_port_sym_crypto_writer_params *conf =3D > + params; > + struct rte_port_sym_crypto_writer *port; > + > + /* Check input parameters */ > + if ((conf =3D=3D NULL) || > + (conf->tx_burst_sz =3D=3D 0) || > + (conf->tx_burst_sz > RTE_PORT_IN_BURST_SIZE_MAX) || > + (!rte_is_power_of_2(conf->tx_burst_sz))) { > + RTE_LOG(ERR, PORT, "%s: Invalid input parameters\n", > __func__); > + return NULL; > + } > + > + /* Memory allocation */ > + port =3D rte_zmalloc_socket("PORT", sizeof(*port), > + RTE_CACHE_LINE_SIZE, socket_id); > + if (port =3D=3D NULL) { > + RTE_LOG(ERR, PORT, "%s: Failed to allocate port\n", > __func__); > + return NULL; > + } > + > + /* Initialization */ > + port->tx_burst_sz =3D conf->tx_burst_sz; > + port->tx_buf_count =3D 0; > + port->bsz_mask =3D 1LLU << (conf->tx_burst_sz - 1); > + > + port->cryptodev_id =3D conf->cryptodev_id; > + port->queue_id =3D conf->queue_id; > + port->crypto_op_offset =3D conf->crypto_op_offset; > + > + return port; > +} > + > +static inline void > +send_burst(struct rte_port_sym_crypto_writer *p) > +{ > + uint32_t nb_tx; > + > + nb_tx =3D rte_cryptodev_enqueue_burst(p->cryptodev_id, p->queue_id, > + p->tx_buf, p->tx_buf_count); > + > + RTE_PORT_SYM_CRYPTO_WRITER_STATS_PKTS_DROP_ADD(p, p- > >tx_buf_count - > + nb_tx); > + for (; nb_tx < p->tx_buf_count; nb_tx++) > + rte_pktmbuf_free(p->tx_buf[nb_tx]->sym->m_src); > + > + p->tx_buf_count =3D 0; > +} > + > +static int > +rte_port_sym_crypto_writer_tx(void *port, struct rte_mbuf *pkt) > +{ > + struct rte_port_sym_crypto_writer *p =3D > + port; > + > + p->tx_buf[p->tx_buf_count++] =3D (struct rte_crypto_op *) > + RTE_MBUF_METADATA_UINT8_PTR(pkt, p- > >crypto_op_offset); > + RTE_PORT_SYM_CRYPTO_WRITER_STATS_PKTS_IN_ADD(p, 1); > + if (p->tx_buf_count >=3D p->tx_burst_sz) > + send_burst(p); > + > + return 0; > +} > + > +static int > +rte_port_sym_crypto_writer_tx_bulk(void *port, > + struct rte_mbuf **pkts, > + uint64_t pkts_mask) > +{ > + struct rte_port_sym_crypto_writer *p =3D > + port; > + uint64_t bsz_mask =3D p->bsz_mask; > + uint32_t tx_buf_count =3D p->tx_buf_count; > + uint64_t expr =3D (pkts_mask & (pkts_mask + 1)) | > + ((pkts_mask & bsz_mask) ^ > bsz_mask); > + > + if (expr =3D=3D 0) { > + uint64_t n_pkts =3D __builtin_popcountll(pkts_mask); > + uint32_t i; > + > + RTE_PORT_SYM_CRYPTO_WRITER_STATS_PKTS_IN_ADD(p, > n_pkts); > + > + for (i =3D 0; i < n_pkts; i++) > + p->tx_buf[p->tx_buf_count++] =3D (struct > rte_crypto_op *) > + > RTE_MBUF_METADATA_UINT8_PTR(pkts[i], > + p- > >crypto_op_offset); > + > + if (p->tx_buf_count >=3D p->tx_burst_sz) > + send_burst(p); > + } else { > + for (; pkts_mask;) { > + uint32_t pkt_index =3D __builtin_ctzll(pkts_mask); > + uint64_t pkt_mask =3D 1LLU << pkt_index; > + struct rte_mbuf *pkt =3D pkts[pkt_index]; > + > + p->tx_buf[tx_buf_count++] =3D (struct rte_crypto_op *) > + > RTE_MBUF_METADATA_UINT8_PTR(pkt, > + p- > >crypto_op_offset); > + > + > RTE_PORT_SYM_CRYPTO_WRITER_STATS_PKTS_IN_ADD(p, 1); > + pkts_mask &=3D ~pkt_mask; > + } > + > + p->tx_buf_count =3D tx_buf_count; > + if (tx_buf_count >=3D p->tx_burst_sz) > + send_burst(p); > + } > + > + return 0; > +} > + > +static int > +rte_port_sym_crypto_writer_flush(void *port) > +{ > + struct rte_port_sym_crypto_writer *p =3D > + port; > + > + if (p->tx_buf_count > 0) > + send_burst(p); > + > + return 0; > +} > + > +static int > +rte_port_sym_crypto_writer_free(void *port) > +{ > + if (port =3D=3D NULL) { > + RTE_LOG(ERR, PORT, "%s: Port is NULL\n", __func__); > + return -EINVAL; > + } > + > + rte_port_sym_crypto_writer_flush(port); > + rte_free(port); > + > + return 0; > +} > + > +static int rte_port_sym_crypto_writer_stats_read(void *port, > + struct rte_port_out_stats *stats, int clear) > +{ > + struct rte_port_sym_crypto_writer *p =3D > + port; > + > + if (stats !=3D NULL) > + memcpy(stats, &p->stats, sizeof(p->stats)); > + > + if (clear) > + memset(&p->stats, 0, sizeof(p->stats)); > + > + return 0; > +} > + > +/* > + * Port crypto Writer Nodrop > + */ > +#ifdef RTE_PORT_STATS_COLLECT > + > +#define > RTE_PORT_SYM_CRYPTO_WRITER_NODROP_STATS_PKTS_IN_ADD(port, > val) \ > + port->stats.n_pkts_in +=3D val > +#define > RTE_PORT_SYM_CRYPTO_WRITER_NODROP_STATS_PKTS_DROP_ADD(port, > val) \ > + port->stats.n_pkts_drop +=3D val > + > +#else > + > +#define > RTE_PORT_SYM_CRYPTO_WRITER_NODROP_STATS_PKTS_IN_ADD(port, > val) > +#define > RTE_PORT_SYM_CRYPTO_WRITER_NODROP_STATS_PKTS_DROP_ADD(port, > val) > + > +#endif > + > +struct rte_port_sym_crypto_writer_nodrop { > + struct rte_port_out_stats stats; > + > + struct rte_crypto_op *tx_buf[2 * RTE_PORT_IN_BURST_SIZE_MAX]; > + uint32_t tx_burst_sz; > + uint32_t tx_buf_count; > + uint64_t bsz_mask; > + uint64_t n_retries; > + > + uint8_t cryptodev_id; > + uint16_t queue_id; > + uint16_t crypto_op_offset; > +}; > + > +static void * > +rte_port_sym_crypto_writer_nodrop_create(void *params, int socket_id) > +{ > + struct rte_port_sym_crypto_writer_nodrop_params *conf =3D > + params; > + struct rte_port_sym_crypto_writer_nodrop *port; > + > + /* Check input parameters */ > + if ((conf =3D=3D NULL) || > + (conf->tx_burst_sz =3D=3D 0) || > + (conf->tx_burst_sz > RTE_PORT_IN_BURST_SIZE_MAX) || > + (!rte_is_power_of_2(conf->tx_burst_sz))) { > + RTE_LOG(ERR, PORT, "%s: Invalid input parameters\n", > __func__); > + return NULL; > + } > + > + /* Memory allocation */ > + port =3D rte_zmalloc_socket("PORT", sizeof(*port), > + RTE_CACHE_LINE_SIZE, socket_id); > + if (port =3D=3D NULL) { > + RTE_LOG(ERR, PORT, "%s: Failed to allocate port\n", > __func__); > + return NULL; > + } > + > + /* Initialization */ > + port->cryptodev_id =3D conf->cryptodev_id; > + port->queue_id =3D conf->queue_id; > + port->crypto_op_offset =3D conf->crypto_op_offset; > + port->tx_burst_sz =3D conf->tx_burst_sz; > + port->tx_buf_count =3D 0; > + port->bsz_mask =3D 1LLU << (conf->tx_burst_sz - 1); > + > + /* > + * When n_retries is 0 it means that we should wait for every packet > to > + * send no matter how many retries should it take. To limit number > of > + * branches in fast path, we use UINT64_MAX instead of branching. > + */ > + port->n_retries =3D (conf->n_retries =3D=3D 0) ? UINT64_MAX : conf- > >n_retries; > + > + return port; > +} > + > +static inline void > +send_burst_nodrop(struct rte_port_sym_crypto_writer_nodrop *p) > +{ > + uint32_t nb_tx =3D 0, i; > + > + nb_tx =3D rte_cryptodev_enqueue_burst(p->cryptodev_id, p->queue_id, > + p->tx_buf, p->tx_buf_count); > + > + /* We sent all the packets in a first try */ > + if (nb_tx >=3D p->tx_buf_count) { > + p->tx_buf_count =3D 0; > + return; > + } > + > + for (i =3D 0; i < p->n_retries; i++) { > + nb_tx +=3D rte_cryptodev_enqueue_burst(p->cryptodev_id, > + p->queue_id, p->tx_buf + nb_tx, > + p->tx_buf_count - nb_tx); > + > + /* We sent all the packets in more than one try */ > + if (nb_tx >=3D p->tx_buf_count) { > + p->tx_buf_count =3D 0; > + return; > + } > + } > + > + /* We didn't send the packets in maximum allowed attempts */ > + > RTE_PORT_SYM_CRYPTO_WRITER_NODROP_STATS_PKTS_DROP_A > DD(p, > + p->tx_buf_count - nb_tx); > + for ( ; nb_tx < p->tx_buf_count; nb_tx++) > + rte_pktmbuf_free(p->tx_buf[nb_tx]->sym->m_src); > + > + p->tx_buf_count =3D 0; > +} > + > +static int > +rte_port_sym_crypto_writer_nodrop_tx(void *port, struct rte_mbuf *pkt) > +{ > + struct rte_port_sym_crypto_writer_nodrop *p =3D > + port; > + > + p->tx_buf[p->tx_buf_count++] =3D (struct rte_crypto_op *) > + RTE_MBUF_METADATA_UINT8_PTR(pkt, p- > >crypto_op_offset); > + RTE_PORT_SYM_CRYPTO_WRITER_STATS_PKTS_IN_ADD(p, 1); > + if (p->tx_buf_count >=3D p->tx_burst_sz) > + send_burst_nodrop(p); > + > + return 0; > +} > + > +static int > +rte_port_sym_crypto_writer_nodrop_tx_bulk(void *port, > + struct rte_mbuf **pkts, > + uint64_t pkts_mask) > +{ > + struct rte_port_sym_crypto_writer_nodrop *p =3D > + port; > + > + uint64_t bsz_mask =3D p->bsz_mask; > + uint32_t tx_buf_count =3D p->tx_buf_count; > + uint64_t expr =3D (pkts_mask & (pkts_mask + 1)) | > + ((pkts_mask & bsz_mask) ^ > bsz_mask); > + > + if (expr =3D=3D 0) { > + uint64_t n_pkts =3D __builtin_popcountll(pkts_mask); > + uint32_t i; > + > + > RTE_PORT_SYM_CRYPTO_WRITER_NODROP_STATS_PKTS_IN_ADD( > p, n_pkts); > + > + for (i =3D 0; i < n_pkts; i++) > + p->tx_buf[p->tx_buf_count++] =3D (struct > rte_crypto_op *) > + > RTE_MBUF_METADATA_UINT8_PTR(pkts[i], > + p- > >crypto_op_offset); > + > + if (p->tx_buf_count >=3D p->tx_burst_sz) > + send_burst_nodrop(p); > + } else { > + for ( ; pkts_mask; ) { > + uint32_t pkt_index =3D __builtin_ctzll(pkts_mask); > + uint64_t pkt_mask =3D 1LLU << pkt_index; > + struct rte_mbuf *pkt =3D pkts[pkt_index]; > + > + p->tx_buf[tx_buf_count++] =3D (struct rte_crypto_op *) > + > RTE_MBUF_METADATA_UINT8_PTR(pkt, > + p- > >crypto_op_offset); > + > RTE_PORT_SYM_CRYPTO_WRITER_NODROP_STATS_PKTS_IN_ADD( > p, > + 1); > + pkts_mask &=3D ~pkt_mask; > + } > + > + p->tx_buf_count =3D tx_buf_count; > + if (tx_buf_count >=3D p->tx_burst_sz) > + send_burst_nodrop(p); > + } > + > + return 0; > +} > + > +static int > +rte_port_sym_crypto_writer_nodrop_flush(void *port) > +{ > + struct rte_port_sym_crypto_writer_nodrop *p =3D > + port; > + > + if (p->tx_buf_count > 0) > + send_burst_nodrop(p); > + > + return 0; > +} > + > +static int > +rte_port_sym_crypto_writer_nodrop_free(void *port) > +{ > + if (port =3D=3D NULL) { > + RTE_LOG(ERR, PORT, "%s: Port is NULL\n", __func__); > + return -EINVAL; > + } > + > + rte_port_sym_crypto_writer_nodrop_flush(port); > + rte_free(port); > + > + return 0; > +} > + > +static int rte_port_sym_crypto_writer_nodrop_stats_read(void *port, > + struct rte_port_out_stats *stats, int clear) > +{ > + struct rte_port_sym_crypto_writer_nodrop *p =3D > + port; > + > + if (stats !=3D NULL) > + memcpy(stats, &p->stats, sizeof(p->stats)); > + > + if (clear) > + memset(&p->stats, 0, sizeof(p->stats)); > + > + return 0; > +} > + > + > +/* > + * Summary of port operations > + */ > +struct rte_port_in_ops __rte_experimental > rte_port_sym_crypto_reader_ops =3D { > + .f_create =3D rte_port_sym_crypto_reader_create, > + .f_free =3D rte_port_sym_crypto_reader_free, > + .f_rx =3D rte_port_sym_crypto_reader_rx, > + .f_stats =3D rte_port_sym_crypto_reader_stats_read, > +}; > + > +struct rte_port_out_ops __rte_experimental > rte_port_sym_crypto_writer_ops =3D { > + .f_create =3D rte_port_sym_crypto_writer_create, > + .f_free =3D rte_port_sym_crypto_writer_free, > + .f_tx =3D rte_port_sym_crypto_writer_tx, > + .f_tx_bulk =3D rte_port_sym_crypto_writer_tx_bulk, > + .f_flush =3D rte_port_sym_crypto_writer_flush, > + .f_stats =3D rte_port_sym_crypto_writer_stats_read, > +}; > + > +struct rte_port_out_ops __rte_experimental > +rte_port_sym_crypto_writer_nodrop_ops =3D { > + .f_create =3D rte_port_sym_crypto_writer_nodrop_create, > + .f_free =3D rte_port_sym_crypto_writer_nodrop_free, > + .f_tx =3D rte_port_sym_crypto_writer_nodrop_tx, > + .f_tx_bulk =3D rte_port_sym_crypto_writer_nodrop_tx_bulk, > + .f_flush =3D rte_port_sym_crypto_writer_nodrop_flush, > + .f_stats =3D rte_port_sym_crypto_writer_nodrop_stats_read, > +}; > diff --git a/lib/librte_port/rte_port_sym_crypto.h > b/lib/librte_port/rte_port_sym_crypto.h > new file mode 100644 > index 000000000..daf4a36dd > --- /dev/null > +++ b/lib/librte_port/rte_port_sym_crypto.h > @@ -0,0 +1,97 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 Intel Corporation > + */ > + > +#ifndef __INCLUDE_RTE_PORT_SYM_CRYPTO_H__ > +#define __INCLUDE_RTE_PORT_SYM_CRYPTO_H__ > + > +#ifdef __cplusplus > +extern "C" { > +#endif > + > +/** > + * @file > + * RTE Port sym crypto Interface > + * > + * crypto_reader: input port built on top of pre-initialized crypto inte= rface > + * crypto_writer: output port built on top of pre-initialized crypto int= erface > + * > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + ***/ > + > +#include > + > +#include > + > +#include "rte_port.h" > + > +/** Function prototype for reader post action. */ > +typedef void (*rte_port_sym_crypto_reader_callback_fn)(struct rte_mbuf > **pkts, > + uint16_t n_pkts, void *arg); > + > +/** Crypto_reader port parameters */ > +struct rte_port_sym_crypto_reader_params { > + /** Target cryptodev ID. */ > + uint8_t cryptodev_id; > + > + /** Target cryptodev Queue Pair ID. */ > + uint16_t queue_id; > + > + /** Crypto reader post callback function. */ > + rte_port_sym_crypto_reader_callback_fn f_callback; > + > + /** Crypto reader post callback function arguments. */ > + void *arg_callback; > +}; > + > +/** Crypto_reader port operations. */ > +extern struct rte_port_in_ops __rte_experimental > +rte_port_sym_crypto_reader_ops; > + > + > +/** Crypto_writer port parameters. */ > +struct rte_port_sym_crypto_writer_params { > + /** Target cryptodev ID. */ > + uint8_t cryptodev_id; > + > + /** Target cryptodev Queue Pair ID. */ > + uint16_t queue_id; > + > + /** offset to rte_crypto_op in the mbufs. */ > + uint16_t crypto_op_offset; > + > + /** Burst size to crypto interface. */ > + uint32_t tx_burst_sz; > +}; > + > +/** Crypto_writer port operations. */ > +extern struct rte_port_out_ops __rte_experimental > +rte_port_sym_crypto_writer_ops; > + > +/** Crypto_writer_nodrop port parameters. */ > +struct rte_port_sym_crypto_writer_nodrop_params { > + /** Target cryptodev ID. */ > + uint8_t cryptodev_id; > + > + /** Target cryptodev queue pair id. */ > + uint16_t queue_id; > + > + /** Offset to rte_crypto_op in the mbufs. */ > + uint16_t crypto_op_offset; > + > + /** Burst size to crypto interface. */ > + uint32_t tx_burst_sz; > + > + /** Maximum number of retries, 0 for no limit. */ > + uint32_t n_retries; > +}; > + > +/** Crypto_writer_nodrop port operations. */ > +extern struct rte_port_out_ops rte_port_sym_crypto_writer_nodrop_ops; > + > +#ifdef __cplusplus > +} > +#endif > + > +#endif > diff --git a/lib/librte_port/rte_port_version.map > b/lib/librte_port/rte_port_version.map > index 6470629b4..20e45a0ef 100644 > --- a/lib/librte_port/rte_port_version.map > +++ b/lib/librte_port/rte_port_version.map > @@ -51,3 +51,11 @@ DPDK_16.11 { > rte_port_fd_writer_nodrop_ops; >=20 > } DPDK_16.07; > + > +EXPERIMENTAL { > + global: > + > + rte_port_sym_crypto_reader_ops; > + rte_port_sym_crypto_writer_ops; > + rte_port_sym_crypto_writer_nodrop_ops; > +}; > -- > 2.13.6 For some reason, not sure exactly why, there is this assembler warning, any= idea of the cause? =3D=3D Build lib/librte_port CC rte_port_sym_crypto.o /tmp/ccn9NRFm.s: Assembler messages: /tmp/ccn9NRFm.s:4984: Warning: setting incorrect section attributes for .te= xt.experimental AR librte_port.a INSTALL-LIB librte_port.a