From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id C47FB1E25 for ; Mon, 8 Oct 2018 12:35:43 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2018 03:35:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,356,1534834800"; d="scan'208";a="270451221" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga006.fm.intel.com with ESMTP; 08 Oct 2018 03:35:42 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by irsmsx105.ger.corp.intel.com ([169.254.7.89]) with mapi id 14.03.0319.002; Mon, 8 Oct 2018 11:35:41 +0100 From: "Dumitrescu, Cristian" To: "Pattan, Reshma" , "dev@dpdk.org" , "Singh, Jasvinder" Thread-Topic: [PATCH v3] net/softnic: add flow flush API Thread-Index: AQHUXubzIw505YaYI0i/VYonOA03jKUVJhug Date: Mon, 8 Oct 2018 10:35:40 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E7D5883@IRSMSX107.ger.corp.intel.com> References: <1538411914-12721-1-git-send-email-reshma.pattan@intel.com> <1538989812-725-1-git-send-email-reshma.pattan@intel.com> In-Reply-To: <1538989812-725-1-git-send-email-reshma.pattan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDVmNmExMWQtMzAyMS00ODEzLWI1NjUtNzg3Y2ZiZWM3YWI1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNzlPUXZ5N081UFpWRGRmZGYzXC8xZ2I2a1dnYmhQRUtzOGtwK04yd2dObnR4R3AzbXBIUkgyUnNobzhqQlh2SGIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/softnic: add flow flush API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 10:35:44 -0000 > -----Original Message----- > From: Pattan, Reshma > Sent: Monday, October 8, 2018 10:10 AM > To: dev@dpdk.org; Dumitrescu, Cristian ; > Singh, Jasvinder > Cc: Pattan, Reshma > Subject: [PATCH v3] net/softnic: add flow flush API >=20 > Add rte flow flush api for flushing > all the flows of the port. >=20 > Signed-off-by: Reshma Pattan > --- > v3: Some style related changes > v2: Use TAILQ_FOREACH_SAFE instead of TAILQ_FOREACH > for safe removal using TAILQ_REMOVAL. > --- > drivers/net/softnic/rte_eth_softnic_flow.c | 47 +++++++++++++++++++++- > 1 file changed, 46 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c > b/drivers/net/softnic/rte_eth_softnic_flow.c > index 03d41bc01..08ea6e940 100644 > --- a/drivers/net/softnic/rte_eth_softnic_flow.c > +++ b/drivers/net/softnic/rte_eth_softnic_flow.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include >=20 > #include "rte_eth_softnic_internals.h" > #include "rte_eth_softnic.h" > @@ -1915,6 +1916,50 @@ pmd_flow_destroy(struct rte_eth_dev *dev, > return 0; > } >=20 > +static int > +pmd_flow_flush(struct rte_eth_dev *dev, > + struct rte_flow_error *error) > +{ > + struct pmd_internals *softnic =3D dev->data->dev_private; > + struct pipeline *pipeline; > + uint32_t i; > + > + TAILQ_FOREACH(pipeline, &softnic->pipeline_list, node) { > + /* Remove all the flows added to the tables. */ > + for (i =3D 0; i < pipeline->n_tables; i++) { > + struct softnic_table *table =3D &pipeline->table[i]; > + struct rte_flow *flow; > + void *temp; > + int status; > + > + TAILQ_FOREACH_SAFE(flow, &table->flows, node, > temp) { > + /* Rule delete. */ > + status =3D softnic_pipeline_table_rule_delete > + (softnic, > + pipeline->name, > + i, > + &flow->match); > + if (status) > + return rte_flow_error_set(error, > + EINVAL, > + > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, > + NULL, > + "Pipeline table rule delete > failed"); When rule deletion fails, you should not abort, but set up a flag and conti= nue to delete the remaining rules. > + > + /* Update dependencies */ > + if (is_meter_action_enable(softnic, table)) > + flow_meter_owner_reset(softnic, > flow); > + > + /* Flow delete. */ > + TAILQ_REMOVE(&table->flows, flow, node); > + free(flow); > + } > + } > + } > + This is the place to examine the above mentioned flag and set the error fun= ction argument. If error, the error message basically says "some of the rul= es could not be deleted". > + return 0; > +} > + > static int > pmd_flow_query(struct rte_eth_dev *dev __rte_unused, > struct rte_flow *flow, > @@ -1971,7 +2016,7 @@ const struct rte_flow_ops pmd_flow_ops =3D { > .validate =3D pmd_flow_validate, > .create =3D pmd_flow_create, > .destroy =3D pmd_flow_destroy, > - .flush =3D NULL, > + .flush =3D pmd_flow_flush, > .query =3D pmd_flow_query, > .isolate =3D NULL, > }; > -- > 2.17.1