From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Cc: "Byrne, Stephen1" <stephen1.byrne@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc/qos_meter: update application information
Date: Mon, 15 Oct 2018 15:54:34 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E7D9C4C@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <20181012140337.22570-1-vipin.varghese@intel.com>
> -----Original Message-----
> From: Varghese, Vipin
> Sent: Friday, October 12, 2018 3:04 PM
> To: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>;
> Singh, Jasvinder <jasvinder.singh@intel.com>
> Cc: Byrne, Stephen1 <stephen1.byrne@intel.com>; Varghese, Vipin
> <vipin.varghese@intel.com>
> Subject: [PATCH] doc/qos_meter: update application information
>
> THe change adds special note for colour blind and porfile_table
> actions. In colour blind mode, the previous colour value is
> always 0. For DROP action, one needs to edit the profile_table
> entries apporpiately.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
> doc/guides/sample_app_ug/qos_metering.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/sample_app_ug/qos_metering.rst
> b/doc/guides/sample_app_ug/qos_metering.rst
> index 6391841c6..1ec94b0b3 100644
> --- a/doc/guides/sample_app_ug/qos_metering.rst
> +++ b/doc/guides/sample_app_ug/qos_metering.rst
> @@ -149,3 +149,8 @@ In this particular case:
> * Every packet which color has improved is dropped (this particular case
> can't happen, so these values will not be used).
>
> * For the rest of the cases, the color is changed to red.
> +
> +
> +.. note::
> + * In color blind mode, first row is only valid as previous colour is 0.
Available colors are GREEN, YELLOW and RED, the color is not encoded with a numeric value such as 0. You might want to say GREEN?
> + * To drop the packet, policer_table action has to be set to DROP.
> --
> 2.17.1
next prev parent reply other threads:[~2018-10-15 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 14:03 Vipin Varghese
2018-10-15 15:54 ` Dumitrescu, Cristian [this message]
2018-10-20 14:10 ` Varghese, Vipin
2018-10-22 9:30 ` Dumitrescu, Cristian
2018-10-30 3:56 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D891268E7D9C4C@IRSMSX107.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=stephen1.byrne@intel.com \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).