* [dpdk-dev] [PATCH] examples/ip_pipeline: fix null pointer deref
@ 2018-11-09 16:12 Jasvinder Singh
2018-11-09 16:58 ` Dumitrescu, Cristian
2018-11-12 16:43 ` Dumitrescu, Cristian
0 siblings, 2 replies; 3+ messages in thread
From: Jasvinder Singh @ 2018-11-09 16:12 UTC (permalink / raw)
To: dev; +Cc: cristian.dumitrescu
Fixes null pointer dereference issue raised by coverity.
Coverity issue: 325728, 325729, 325731, 325738
Fixes: 27b333b23237 ("examples/ip_pipeline: track table rules on add bulk")
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
examples/ip_pipeline/cli.c | 28 +++++++++++++++++-----------
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index 3de620682..910386282 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -6841,20 +6841,26 @@ cli_rule_file_process(const char *file_name,
return 0;
cli_rule_file_process_free:
- *rule_list = NULL;
- *n_rules = rule_id;
- *line_number = line_id;
+ if (rule_list != NULL)
+ *rule_list = NULL;
- for ( ; ; ) {
- struct table_rule *rule;
+ if (n_rules != NULL)
+ *n_rules = rule_id;
- rule = TAILQ_FIRST(list);
- if (rule == NULL)
- break;
+ if (line_number != NULL)
+ *line_number = line_id;
- TAILQ_REMOVE(list, rule, node);
- free(rule);
- }
+ if (list != NULL)
+ for ( ; ; ) {
+ struct table_rule *rule;
+
+ rule = TAILQ_FIRST(list);
+ if (rule == NULL)
+ break;
+
+ TAILQ_REMOVE(list, rule, node);
+ free(rule);
+ }
if (f)
fclose(f);
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix null pointer deref
2018-11-09 16:12 [dpdk-dev] [PATCH] examples/ip_pipeline: fix null pointer deref Jasvinder Singh
@ 2018-11-09 16:58 ` Dumitrescu, Cristian
2018-11-12 16:43 ` Dumitrescu, Cristian
1 sibling, 0 replies; 3+ messages in thread
From: Dumitrescu, Cristian @ 2018-11-09 16:58 UTC (permalink / raw)
To: Singh, Jasvinder, dev
> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Friday, November 9, 2018 4:12 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix null pointer deref
>
> Fixes null pointer dereference issue raised by coverity.
>
> Coverity issue: 325728, 325729, 325731, 325738
> Fixes: 27b333b23237 ("examples/ip_pipeline: track table rules on add bulk")
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> examples/ip_pipeline/cli.c | 28 +++++++++++++++++-----------
> 1 file changed, 17 insertions(+), 11 deletions(-)
>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix null pointer deref
2018-11-09 16:12 [dpdk-dev] [PATCH] examples/ip_pipeline: fix null pointer deref Jasvinder Singh
2018-11-09 16:58 ` Dumitrescu, Cristian
@ 2018-11-12 16:43 ` Dumitrescu, Cristian
1 sibling, 0 replies; 3+ messages in thread
From: Dumitrescu, Cristian @ 2018-11-12 16:43 UTC (permalink / raw)
To: Singh, Jasvinder, dev
> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Friday, November 9, 2018 4:12 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix null pointer deref
>
> Fixes null pointer dereference issue raised by coverity.
>
> Coverity issue: 325728, 325729, 325731, 325738
> Fixes: 27b333b23237 ("examples/ip_pipeline: track table rules on add bulk")
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> examples/ip_pipeline/cli.c | 28 +++++++++++++++++-----------
> 1 file changed, 17 insertions(+), 11 deletions(-)
>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied to next-pipeline tree, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-12 16:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-09 16:12 [dpdk-dev] [PATCH] examples/ip_pipeline: fix null pointer deref Jasvinder Singh
2018-11-09 16:58 ` Dumitrescu, Cristian
2018-11-12 16:43 ` Dumitrescu, Cristian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).