From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id F2C691B485 for ; Fri, 4 Jan 2019 12:17:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jan 2019 03:17:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,438,1539673200"; d="scan'208";a="307436891" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga006.fm.intel.com with ESMTP; 04 Jan 2019 03:17:12 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.205]) by IRSMSX103.ger.corp.intel.com ([169.254.3.60]) with mapi id 14.03.0415.000; Fri, 4 Jan 2019 11:17:11 +0000 From: "Dumitrescu, Cristian" To: "Iremonger, Bernard" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Wu, Jingjing" Thread-Topic: [PATCH] app/test-pmd: stop all ports before any close Thread-Index: AQHUpBaHP96w7A42/0Carar5hs/l2aWe9NUg Date: Fri, 4 Jan 2019 11:17:11 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E82451B@IRSMSX108.ger.corp.intel.com> References: <20190103163705.45497-1-cristian.dumitrescu@intel.com> <8CEF83825BEC744B83065625E567D7C260D4A306@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D4A306@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjA2ZWRjNDYtY2E5MS00NDU5LWIzOGQtMTQ2OTE4ZDM3MjY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieFJvNmFCQ3o0R00zWmY1cVVQemVNUDFZTEVKdnlcL0o3bWttXC90cXZCTkQ0KzNIdk1SUjF1cVJ1Q2J3STZTa0ZXIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test-pmd: stop all ports before any close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 11:17:14 -0000 Hi Bernard, Thanks for reviewing this patch. > -----Original Message----- > From: Iremonger, Bernard > Sent: Friday, January 4, 2019 10:16 AM > To: Dumitrescu, Cristian ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > > Subject: RE: [PATCH] app/test-pmd: stop all ports before any close >=20 > Hi Cristian, >=20 > > -----Original Message----- > > From: Dumitrescu, Cristian > > Sent: Thursday, January 3, 2019 4:37 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Wu, Jingjing > > ; Iremonger, Bernard > > > Subject: [PATCH] app/test-pmd: stop all ports before any close >=20 > ./devtools/check-git-log.sh -1 > Wrong headline label: > app/test-pmd: stop all ports before any close >=20 > Should be app/testpmd Will fix. >=20 > The commit message should also have the "fix" keyword >=20 We can treat this as a fix or as an improvement, I was not sure about what = people think. I don't mind either way. Will treat this as a fix then in v2. > > > > This patch proposes a slightly different test-pmd quit operation: stop = all > devices > > before starting to close any device. Basically, stop all moving parts b= efore > > beginning to remove them. The current test-pmd quit is stoping and clos= ing > each > > device before moving to the next device. > > > > If all devices in the system are independent of each other, this differ= ence is > > usually not important. In case of Soft NIC devices, any such virtual de= vice > > typically depends on one or more physical devices being alive, as it ac= cesses > > their queues, so this difference becomes important. > > > > Without this straightforward fix, all the Soft NIC devices need to be > manually > > stopped before the quit command is issued, otherwise the quit command > can > > sometimes crash the test-pmd application. >=20 > There should be a fixes line before the sign-off, and maybe a " Cc: > stable@dpdk.org" line >=20 > > Signed-off-by: Cristian Dumitrescu > > --- > > app/test-pmd/testpmd.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > 8d584b008..15a948828 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -2391,9 +2391,13 @@ pmd_test_exit(void) > > if (ports !=3D NULL) { > > no_link_check =3D 1; > > RTE_ETH_FOREACH_DEV(pt_id) { > > - printf("\nShutting down port %d...\n", pt_id); > > + printf("\nStopping port %d...\n", pt_id); > > fflush(stdout); > > stop_port(pt_id); > > + } > > + RTE_ETH_FOREACH_DEV(pt_id) { > > + printf("\nShutting down port %d...\n", pt_id); > > + fflush(stdout); > > close_port(pt_id); > > > > /* > > -- > > 2.17.1 >=20 > Regards, >=20 > Bernard. Regards, Cristian